Skip to content

Commit 498d926

Browse files
committed
Only visit syntax nodes for nominal declarations
1 parent cc09066 commit 498d926

File tree

2 files changed

+0
-104
lines changed

2 files changed

+0
-104
lines changed

Sources/SwiftFormat/Core/Pipelines+Generated.swift

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,6 @@ class LintPipeline: SyntaxVisitor {
4444
onVisitPost(rule: NoEmptyLinesOpeningClosingBraces.self, for: node)
4545
}
4646

47-
override func visit(_ node: AccessorDeclSyntax) -> SyntaxVisitorContinueKind {
48-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
49-
return .visitChildren
50-
}
51-
override func visitPost(_ node: AccessorDeclSyntax) {
52-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
53-
}
54-
5547
override func visit(_ node: ActorDeclSyntax) -> SyntaxVisitorContinueKind {
5648
visitIfEnabled(AllPublicDeclarationsHaveDocumentation.visit, for: node)
5749
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
@@ -179,25 +171,15 @@ class LintPipeline: SyntaxVisitor {
179171
override func visit(_ node: DeinitializerDeclSyntax) -> SyntaxVisitorContinueKind {
180172
visitIfEnabled(AllPublicDeclarationsHaveDocumentation.visit, for: node)
181173
visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, for: node)
182-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
183174
visitIfEnabled(UseTripleSlashForDocumentationComments.visit, for: node)
184175
return .visitChildren
185176
}
186177
override func visitPost(_ node: DeinitializerDeclSyntax) {
187178
onVisitPost(rule: AllPublicDeclarationsHaveDocumentation.self, for: node)
188179
onVisitPost(rule: BeginDocumentationCommentWithOneLineSummary.self, for: node)
189-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
190180
onVisitPost(rule: UseTripleSlashForDocumentationComments.self, for: node)
191181
}
192182

193-
override func visit(_ node: EditorPlaceholderDeclSyntax) -> SyntaxVisitorContinueKind {
194-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
195-
return .visitChildren
196-
}
197-
override func visitPost(_ node: EditorPlaceholderDeclSyntax) {
198-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
199-
}
200-
201183
override func visit(_ node: EnumCaseDeclSyntax) -> SyntaxVisitorContinueKind {
202184
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
203185
return .visitChildren
@@ -380,14 +362,6 @@ class LintPipeline: SyntaxVisitor {
380362
onVisitPost(rule: UseShorthandTypeNames.self, for: node)
381363
}
382364

383-
override func visit(_ node: IfConfigDeclSyntax) -> SyntaxVisitorContinueKind {
384-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
385-
return .visitChildren
386-
}
387-
override func visitPost(_ node: IfConfigDeclSyntax) {
388-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
389-
}
390-
391365
override func visit(_ node: IfExprSyntax) -> SyntaxVisitorContinueKind {
392366
visitIfEnabled(NoParensAroundConditions.visit, for: node)
393367
return .visitChildren
@@ -396,14 +370,6 @@ class LintPipeline: SyntaxVisitor {
396370
onVisitPost(rule: NoParensAroundConditions.self, for: node)
397371
}
398372

399-
override func visit(_ node: ImportDeclSyntax) -> SyntaxVisitorContinueKind {
400-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
401-
return .visitChildren
402-
}
403-
override func visitPost(_ node: ImportDeclSyntax) {
404-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
405-
}
406-
407373
override func visit(_ node: InfixOperatorExprSyntax) -> SyntaxVisitorContinueKind {
408374
visitIfEnabled(NoAssignmentInExpressions.visit, for: node)
409375
return .visitChildren
@@ -444,14 +410,6 @@ class LintPipeline: SyntaxVisitor {
444410
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
445411
}
446412

447-
override func visit(_ node: MacroExpansionDeclSyntax) -> SyntaxVisitorContinueKind {
448-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
449-
return .visitChildren
450-
}
451-
override func visitPost(_ node: MacroExpansionDeclSyntax) {
452-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
453-
}
454-
455413
override func visit(_ node: MacroExpansionExprSyntax) -> SyntaxVisitorContinueKind {
456414
visitIfEnabled(NoPlaygroundLiterals.visit, for: node)
457415
return .visitChildren
@@ -486,14 +444,6 @@ class LintPipeline: SyntaxVisitor {
486444
onVisitPost(rule: NoEmptyLinesOpeningClosingBraces.self, for: node)
487445
}
488446

489-
override func visit(_ node: MissingDeclSyntax) -> SyntaxVisitorContinueKind {
490-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
491-
return .visitChildren
492-
}
493-
override func visitPost(_ node: MissingDeclSyntax) {
494-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
495-
}
496-
497447
override func visit(_ node: OperatorDeclSyntax) -> SyntaxVisitorContinueKind {
498448
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
499449
return .visitChildren
@@ -522,24 +472,14 @@ class LintPipeline: SyntaxVisitor {
522472
onVisitPost(rule: UseSingleLinePropertyGetter.self, for: node)
523473
}
524474

525-
override func visit(_ node: PoundSourceLocationSyntax) -> SyntaxVisitorContinueKind {
526-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
527-
return .visitChildren
528-
}
529-
override func visitPost(_ node: PoundSourceLocationSyntax) {
530-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
531-
}
532-
533475
override func visit(_ node: PrecedenceGroupDeclSyntax) -> SyntaxVisitorContinueKind {
534476
visitIfEnabled(NoEmptyLinesOpeningClosingBraces.visit, for: node)
535477
visitIfEnabled(NoLeadingUnderscores.visit, for: node)
536-
visitIfEnabled(StandardizeDocumentationComments.visit, for: node)
537478
return .visitChildren
538479
}
539480
override func visitPost(_ node: PrecedenceGroupDeclSyntax) {
540481
onVisitPost(rule: NoEmptyLinesOpeningClosingBraces.self, for: node)
541482
onVisitPost(rule: NoLeadingUnderscores.self, for: node)
542-
onVisitPost(rule: StandardizeDocumentationComments.self, for: node)
543483
}
544484

545485
override func visit(_ node: ProtocolDeclSyntax) -> SyntaxVisitorContinueKind {

Sources/SwiftFormat/Rules/StandardizeDocumentationComments.swift

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@ public final class StandardizeDocumentationComments: SyntaxFormatRule {
3434
// different for different node types (e.g. an accessor has a `body`, while an
3535
// actor has a `memberBlock`).
3636

37-
public override func visit(_ node: AccessorDeclSyntax) -> DeclSyntax {
38-
if var decl = reformatDocumentation(node) {
39-
decl.body = decl.body.map(visit)
40-
return DeclSyntax(decl)
41-
}
42-
return super.visit(node)
43-
}
44-
4537
public override func visit(_ node: ActorDeclSyntax) -> DeclSyntax {
4638
if var decl = reformatDocumentation(node) {
4739
decl.memberBlock = visit(decl.memberBlock)
@@ -62,14 +54,6 @@ public final class StandardizeDocumentationComments: SyntaxFormatRule {
6254
return super.visit(node)
6355
}
6456

65-
public override func visit(_ node: DeinitializerDeclSyntax) -> DeclSyntax {
66-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
67-
}
68-
69-
public override func visit(_ node: EditorPlaceholderDeclSyntax) -> DeclSyntax {
70-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
71-
}
72-
7357
public override func visit(_ node: EnumCaseDeclSyntax) -> DeclSyntax {
7458
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
7559
}
@@ -98,18 +82,6 @@ public final class StandardizeDocumentationComments: SyntaxFormatRule {
9882
return super.visit(node)
9983
}
10084

101-
public override func visit(_ node: IfConfigDeclSyntax) -> DeclSyntax {
102-
if var decl = reformatDocumentation(node) {
103-
decl.clauses = visit(decl.clauses)
104-
return DeclSyntax(decl)
105-
}
106-
return super.visit(node)
107-
}
108-
109-
public override func visit(_ node: ImportDeclSyntax) -> DeclSyntax {
110-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
111-
}
112-
11385
public override func visit(_ node: InitializerDeclSyntax) -> DeclSyntax {
11486
if var decl = reformatDocumentation(node) {
11587
decl.body = decl.body.map(visit)
@@ -122,26 +94,10 @@ public final class StandardizeDocumentationComments: SyntaxFormatRule {
12294
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
12395
}
12496

125-
public override func visit(_ node: MacroExpansionDeclSyntax) -> DeclSyntax {
126-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
127-
}
128-
129-
public override func visit(_ node: MissingDeclSyntax) -> DeclSyntax {
130-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
131-
}
132-
13397
public override func visit(_ node: OperatorDeclSyntax) -> DeclSyntax {
13498
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
13599
}
136100

137-
public override func visit(_ node: PoundSourceLocationSyntax) -> DeclSyntax {
138-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
139-
}
140-
141-
public override func visit(_ node: PrecedenceGroupDeclSyntax) -> DeclSyntax {
142-
reformatDocumentation(DeclSyntax(node)) ?? super.visit(node)
143-
}
144-
145101
public override func visit(_ node: ProtocolDeclSyntax) -> DeclSyntax {
146102
if var decl = reformatDocumentation(node) {
147103
decl.memberBlock = visit(decl.memberBlock)

0 commit comments

Comments
 (0)