[Lint] Extend type capitalization rule to cover actors, associated types and typealias

Author: xedin

Sources/SwiftFormat/Pipelines+Generated.swift

@@ -34,6 +34,11 @@ class LintPipeline: SyntaxVisitor {
     super.init(viewMode: .sourceAccurate)
   }
 
+  override func visit(_ node: ActorDeclSyntax) -> SyntaxVisitorContinueKind {
+    visitIfEnabled(TypeNamesShouldBeCapitalized.visit, for: node)
+    return .visitChildren
+  }
+
   override func visit(_ node: AsExprSyntax) -> SyntaxVisitorContinueKind {
     visitIfEnabled(NeverForceUnwrap.visit, for: node)
     return .visitChildren
@@ -42,6 +47,7 @@ class LintPipeline: SyntaxVisitor {
   override func visit(_ node: AssociatedTypeDeclSyntax) -> SyntaxVisitorContinueKind {
     visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, for: node)
     visitIfEnabled(NoLeadingUnderscores.visit, for: node)
+    visitIfEnabled(TypeNamesShouldBeCapitalized.visit, for: node)
     return .visitChildren
   }
 
@@ -304,6 +310,7 @@ class LintPipeline: SyntaxVisitor {
     visitIfEnabled(AllPublicDeclarationsHaveDocumentation.visit, for: node)
     visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, for: node)
     visitIfEnabled(NoLeadingUnderscores.visit, for: node)
+    visitIfEnabled(TypeNamesShouldBeCapitalized.visit, for: node)
     visitIfEnabled(UseTripleSlashForDocumentationComments.visit, for: node)
     return .visitChildren
   }

Sources/SwiftFormatRules/TypeNamesShouldBeCapitalized.swift

@@ -37,6 +37,21 @@ public final class TypeNamesShouldBeCapitalized : SyntaxLintRule {
     return .visitChildren
   }
 
+  public override func visit(_ node: ActorDeclSyntax) -> SyntaxVisitorContinueKind {
+    diagnoseNameConventionMismatch(node, name: node.name)
+    return .visitChildren
+  }
+
+  public override func visit(_ node: AssociatedTypeDeclSyntax) -> SyntaxVisitorContinueKind {
+    diagnoseNameConventionMismatch(node, name: node.name)
+    return .visitChildren
+  }
+
+  public override func visit(_ node: TypeAliasDeclSyntax) -> SyntaxVisitorContinueKind {
+    diagnoseNameConventionMismatch(node, name: node.name)
+    return .visitChildren
+  }
+
   private func diagnoseNameConventionMismatch<T: DeclSyntaxProtocol>(_ type: T, name: TokenSyntax) {
     if let firstChar = name.text.first, !firstChar.isUppercase {
       diagnose(.capitalizeTypeName(name: name.text), on: type, severity: .convention)

Tests/SwiftFormatRulesTests/TypeNamesShouldBeCapitalizedTests.swift

@@ -24,4 +24,51 @@ final class TypeNamesShouldBeCapitalizedTests: LintOrFormatRuleTestCase {
     XCTAssertNotDiagnosed(.capitalizeTypeName(name: "myType"))
     XCTAssertDiagnosed(.capitalizeTypeName(name: "innerType"))
   }
+
+  func testActors() {
+    let input =
+      """
+      actor myActor {}
+      actor OtherActor {}
+      distributed actor greeter {}
+      distributed actor DistGreeter {}
+      """
+
+    performLint(TypeNamesShouldBeCapitalized.self, input: input)
+
+    XCTAssertDiagnosed(.capitalizeTypeName(name: "myActor"))
+    XCTAssertNotDiagnosed(.capitalizeTypeName(name: "OtherActor"))
+    XCTAssertDiagnosed(.capitalizeTypeName(name: "greeter"))
+    XCTAssertNotDiagnosed(.capitalizeTypeName(name: "DistGreeter"))
+  }
+
+  func testAssociatedTypeandTypeAlias() {
+    let input =
+      """
+      protocol P {
+        associatedtype kind
+        associatedtype OtherKind
+      }
+
+      typealias x = Int
+      typealias Y = String
+
+      struct MyType {
+        typealias data<T> = Y
+
+        func test() {
+          typealias Value<T> = Y
+        }
+      }
+      """
+
+    performLint(TypeNamesShouldBeCapitalized.self, input: input)
+
+    XCTAssertDiagnosed(.capitalizeTypeName(name: "kind"))
+    XCTAssertNotDiagnosed(.capitalizeTypeName(name: "OtherKind"))
+    XCTAssertDiagnosed(.capitalizeTypeName(name: "x"))
+    XCTAssertNotDiagnosed(.capitalizeTypeName(name: "Y"))
+    XCTAssertDiagnosed(.capitalizeTypeName(name: "data"))
+    XCTAssertNotDiagnosed(.capitalizeTypeName(name: "Value"))
+  }
 }