Skip to content

Commit 5682cad

Browse files
authored
Merge pull request #541 from TTOzzi/sync-with-swift-syntax
Rename 'squareBracket' to 'square'
2 parents 4c88a60 + 9c41f46 commit 5682cad

File tree

2 files changed

+21
-23
lines changed

2 files changed

+21
-23
lines changed

Sources/SwiftFormatPrettyPrint/TokenStreamCreator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3222,7 +3222,7 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor {
32223222
private func startsWithOpenDelimiter(_ node: Syntax) -> Bool {
32233223
guard let token = node.firstToken(viewMode: .sourceAccurate) else { return false }
32243224
switch token.tokenKind {
3225-
case .leftBrace, .leftParen, .leftSquareBracket: return true
3225+
case .leftBrace, .leftParen, .leftSquare: return true
32263226
default: return false
32273227
}
32283228
}

Sources/SwiftFormatRules/UseShorthandTypeNames.swift

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,8 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
138138
}
139139
let arrayTypeExpr = makeArrayTypeExpression(
140140
elementType: typeArgument.argumentType,
141-
leftSquareBracket: TokenSyntax.leftSquareBracketToken(leadingTrivia: leadingTrivia),
142-
rightSquareBracket:
143-
TokenSyntax.rightSquareBracketToken(trailingTrivia: trailingTrivia))
141+
leftSquare: TokenSyntax.leftSquareToken(leadingTrivia: leadingTrivia),
142+
rightSquare: TokenSyntax.rightSquareToken(trailingTrivia: trailingTrivia))
144143
newNode = ExprSyntax(arrayTypeExpr)
145144

146145
case "Dictionary":
@@ -151,10 +150,9 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
151150
let dictTypeExpr = makeDictionaryTypeExpression(
152151
keyType: typeArguments.0.argumentType,
153152
valueType: typeArguments.1.argumentType,
154-
leftSquareBracket: TokenSyntax.leftSquareBracketToken(leadingTrivia: leadingTrivia),
153+
leftSquare: TokenSyntax.leftSquareToken(leadingTrivia: leadingTrivia),
155154
colon: TokenSyntax.colonToken(trailingTrivia: .spaces(1)),
156-
rightSquareBracket:
157-
TokenSyntax.rightSquareBracketToken(trailingTrivia: trailingTrivia))
155+
rightSquare: TokenSyntax.rightSquareToken(trailingTrivia: trailingTrivia))
158156
newNode = ExprSyntax(dictTypeExpr)
159157

160158
case "Optional":
@@ -205,9 +203,9 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
205203
trailingTrivia: Trivia
206204
) -> TypeSyntax {
207205
let result = ArrayTypeSyntax(
208-
leftSquareBracket: TokenSyntax.leftSquareBracketToken(leadingTrivia: leadingTrivia),
206+
leftSquare: TokenSyntax.leftSquareToken(leadingTrivia: leadingTrivia),
209207
elementType: element,
210-
rightSquareBracket: TokenSyntax.rightSquareBracketToken(trailingTrivia: trailingTrivia))
208+
rightSquare: TokenSyntax.rightSquareToken(trailingTrivia: trailingTrivia))
211209
return TypeSyntax(result)
212210
}
213211

@@ -220,11 +218,11 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
220218
trailingTrivia: Trivia
221219
) -> TypeSyntax {
222220
let result = DictionaryTypeSyntax(
223-
leftSquareBracket: TokenSyntax.leftSquareBracketToken(leadingTrivia: leadingTrivia),
221+
leftSquare: TokenSyntax.leftSquareToken(leadingTrivia: leadingTrivia),
224222
keyType: key,
225223
colon: TokenSyntax.colonToken(trailingTrivia: .spaces(1)),
226224
valueType: value,
227-
rightSquareBracket: TokenSyntax.rightSquareBracketToken(trailingTrivia: trailingTrivia))
225+
rightSquare: TokenSyntax.rightSquareToken(trailingTrivia: trailingTrivia))
228226
return TypeSyntax(result)
229227
}
230228

@@ -272,18 +270,18 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
272270
/// have a valid expression representation.
273271
private func makeArrayTypeExpression(
274272
elementType: TypeSyntax,
275-
leftSquareBracket: TokenSyntax,
276-
rightSquareBracket: TokenSyntax
273+
leftSquare: TokenSyntax,
274+
rightSquare: TokenSyntax
277275
) -> ArrayExprSyntax? {
278276
guard let elementTypeExpr = expressionRepresentation(of: elementType) else {
279277
return nil
280278
}
281279
return ArrayExprSyntax(
282-
leftSquare: leftSquareBracket,
280+
leftSquare: leftSquare,
283281
elements: ArrayElementListSyntax([
284282
ArrayElementSyntax(expression: elementTypeExpr, trailingComma: nil),
285283
]),
286-
rightSquare: rightSquareBracket)
284+
rightSquare: rightSquare)
287285
}
288286

289287
/// Returns a `DictionaryExprSyntax` whose single key/value pair is the expression representations
@@ -292,9 +290,9 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
292290
private func makeDictionaryTypeExpression(
293291
keyType: TypeSyntax,
294292
valueType: TypeSyntax,
295-
leftSquareBracket: TokenSyntax,
293+
leftSquare: TokenSyntax,
296294
colon: TokenSyntax,
297-
rightSquareBracket: TokenSyntax
295+
rightSquare: TokenSyntax
298296
) -> DictionaryExprSyntax? {
299297
guard
300298
let keyTypeExpr = expressionRepresentation(of: keyType),
@@ -310,9 +308,9 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
310308
trailingComma: nil),
311309
])
312310
return DictionaryExprSyntax(
313-
leftSquare: leftSquareBracket,
311+
leftSquare: leftSquare,
314312
content: .elements(dictElementList),
315-
rightSquare: rightSquareBracket)
313+
rightSquare: rightSquare)
316314
}
317315

318316
/// Returns an `OptionalChainingExprSyntax` whose wrapped expression is the expression
@@ -394,17 +392,17 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
394392
case .arrayType(let arrayType):
395393
let result = makeArrayTypeExpression(
396394
elementType: arrayType.elementType,
397-
leftSquareBracket: arrayType.leftSquareBracket,
398-
rightSquareBracket: arrayType.rightSquareBracket)
395+
leftSquare: arrayType.leftSquare,
396+
rightSquare: arrayType.rightSquare)
399397
return ExprSyntax(result)
400398

401399
case .dictionaryType(let dictionaryType):
402400
let result = makeDictionaryTypeExpression(
403401
keyType: dictionaryType.keyType,
404402
valueType: dictionaryType.valueType,
405-
leftSquareBracket: dictionaryType.leftSquareBracket,
403+
leftSquare: dictionaryType.leftSquare,
406404
colon: dictionaryType.colon,
407-
rightSquareBracket: dictionaryType.rightSquareBracket)
405+
rightSquare: dictionaryType.rightSquare)
408406
return ExprSyntax(result)
409407

410408
case .optionalType(let optionalType):

0 commit comments

Comments
 (0)