NFC: Rename OmitReturns rule into OmitExplicitReturns

Author: xedin

Sources/SwiftFormat/Core/Pipelines+Generated.swift

@@ -61,7 +61,7 @@ class LintPipeline: SyntaxVisitor {
   }
 
   override func visit(_ node: ClosureExprSyntax) -> SyntaxVisitorContinueKind {
-    visitIfEnabled(OmitReturns.visit, for: node)
+    visitIfEnabled(OmitExplicitReturns.visit, for: node)
     return .visitChildren
   }
 
@@ -151,7 +151,7 @@ class LintPipeline: SyntaxVisitor {
     visitIfEnabled(AlwaysUseLowerCamelCase.visit, for: node)
     visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, for: node)
     visitIfEnabled(NoLeadingUnderscores.visit, for: node)
-    visitIfEnabled(OmitReturns.visit, for: node)
+    visitIfEnabled(OmitExplicitReturns.visit, for: node)
     visitIfEnabled(UseTripleSlashForDocumentationComments.visit, for: node)
     visitIfEnabled(ValidateDocumentationComments.visit, for: node)
     return .visitChildren
@@ -232,7 +232,7 @@ class LintPipeline: SyntaxVisitor {
   }
 
   override func visit(_ node: PatternBindingSyntax) -> SyntaxVisitorContinueKind {
-    visitIfEnabled(OmitReturns.visit, for: node)
+    visitIfEnabled(OmitExplicitReturns.visit, for: node)
     visitIfEnabled(UseSingleLinePropertyGetter.visit, for: node)
     return .visitChildren
   }
@@ -282,7 +282,7 @@ class LintPipeline: SyntaxVisitor {
   override func visit(_ node: SubscriptDeclSyntax) -> SyntaxVisitorContinueKind {
     visitIfEnabled(AllPublicDeclarationsHaveDocumentation.visit, for: node)
     visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, for: node)
-    visitIfEnabled(OmitReturns.visit, for: node)
+    visitIfEnabled(OmitExplicitReturns.visit, for: node)
     visitIfEnabled(UseTripleSlashForDocumentationComments.visit, for: node)
     return .visitChildren
   }
@@ -351,7 +351,7 @@ extension FormatPipeline {
     node = NoLabelsInCasePatterns(context: context).rewrite(node)
     node = NoParensAroundConditions(context: context).rewrite(node)
     node = NoVoidReturnOnFunctionSignature(context: context).rewrite(node)
-    node = OmitReturns(context: context).rewrite(node)
+    node = OmitExplicitReturns(context: context).rewrite(node)
     node = OneCasePerLine(context: context).rewrite(node)
     node = OneVariableDeclarationPerLine(context: context).rewrite(node)
     node = OrderedImports(context: context).rewrite(node)

Sources/SwiftFormat/Core/RuleNameCache+Generated.swift

@@ -37,7 +37,7 @@ public let ruleNameCache: [ObjectIdentifier: String] = [
   ObjectIdentifier(NoLeadingUnderscores.self): "NoLeadingUnderscores",
   ObjectIdentifier(NoParensAroundConditions.self): "NoParensAroundConditions",
   ObjectIdentifier(NoVoidReturnOnFunctionSignature.self): "NoVoidReturnOnFunctionSignature",
-  ObjectIdentifier(OmitReturns.self): "OmitReturns",
+  ObjectIdentifier(OmitExplicitReturns.self): "OmitExplicitReturns",
   ObjectIdentifier(OneCasePerLine.self): "OneCasePerLine",
   ObjectIdentifier(OneVariableDeclarationPerLine.self): "OneVariableDeclarationPerLine",
   ObjectIdentifier(OnlyOneTrailingClosureArgument.self): "OnlyOneTrailingClosureArgument",

Sources/SwiftFormat/Rules/OmitReturns.swift renamed to Sources/SwiftFormat/Rules/OmitExplicitReturns.swift

@@ -19,7 +19,7 @@ import SwiftSyntax
 /// Format: `func <name>() { return ... }` constructs will be replaced with
 ///         equivalent `func <name>() { ... }` constructs.
 @_spi(Rules)
-public final class OmitReturns: SyntaxFormatRule {
+public final class OmitExplicitReturns: SyntaxFormatRule {
   public override class var isOptIn: Bool { return true }
 
   public override func visit(_ node: FunctionDeclSyntax) -> DeclSyntax {

Sources/SwiftFormatConfiguration/RuleRegistry+Generated.swift

@@ -36,7 +36,7 @@ enum RuleRegistry {
     "NoLeadingUnderscores": false,
     "NoParensAroundConditions": true,
     "NoVoidReturnOnFunctionSignature": true,
-    "OmitReturns": false,
+    "OmitExplicitReturns": false,
     "OneCasePerLine": true,
     "OneVariableDeclarationPerLine": true,
     "OnlyOneTrailingClosureArgument": true,

Tests/SwiftFormatTests/Rules/OmitReturnsTests.swift

@@ -5,7 +5,7 @@ import _SwiftFormatTestSupport
 final class OmitReturnsTests: LintOrFormatRuleTestCase {
   func testOmitReturnInFunction() {
     assertFormatting(
-      OmitReturns.self,
+      OmitExplicitReturns.self,
       input: """
         func test() -> Bool {
           1️⃣return false
@@ -23,7 +23,7 @@ final class OmitReturnsTests: LintOrFormatRuleTestCase {
 
   func testOmitReturnInClosure() {
     assertFormatting(
-      OmitReturns.self,
+      OmitExplicitReturns.self,
       input: """
         vals.filter {
           1️⃣return $0.count == 1
@@ -41,7 +41,7 @@ final class OmitReturnsTests: LintOrFormatRuleTestCase {
 
   func testOmitReturnInSubscript() {
     assertFormatting(
-      OmitReturns.self,
+      OmitExplicitReturns.self,
       input: """
         struct Test {
           subscript(x: Int) -> Bool {
@@ -82,7 +82,7 @@ final class OmitReturnsTests: LintOrFormatRuleTestCase {
 
   func testOmitReturnInComputedVars() {
     assertFormatting(
-      OmitReturns.self,
+      OmitExplicitReturns.self,
       input: """
         var x: Int {
           1️⃣return 42