replace redundant deinit complete(count:) call with mark dirty + add tests for deinit bahavior

Author: chloe-yeo

Sources/FoundationEssentials/ProgressManager/ProgressManager+State.swift

@@ -179,12 +179,13 @@ extension ProgressManager {
             return selfFraction.isIndeterminate
         }
 
-        internal func getIsFinished() -> Bool {
+        internal mutating func getIsFinished() -> Bool {
 #if FOUNDATION_FRAMEWORK
             if let interopIsFinished = interopType?.isFinished {
                 return interopIsFinished
             }
 #endif
+            updateChildrenProgressFraction()
             return selfFraction.isFinished
         }
 

Sources/FoundationEssentials/ProgressManager/ProgressManager.swift

@@ -297,11 +297,7 @@ internal import _FoundationCollections
     }
 
     deinit {
-        if let totalCount = self.totalCount {
-            let diff = totalCount - self.completedCount
-            self.complete(count: diff)
-        }
-        
+                
         let (propertiesInt, propertiesDouble, propertiesString, propertiesURL, propertiesUInt64, parents) = state.withLock { state in
             return (state.propertiesInt, state.propertiesDouble, state.propertiesString, state.propertiesURL, state.propertiesUInt64, state.parents)
         }
@@ -344,6 +340,10 @@ internal import _FoundationCollections
         let estimatedTimeRemaining = self.getUpdatedEstimatedTimeRemaining()
         let fileURL = self.getUpdatedFileURL()
 
+        if !isFinished {
+            markSelfDirty(parents: parents)
+        }
+        
         for parentState in parents {
             parentState.parent.setChildDeclaredAdditionalProperties(
                 at: parentState.positionInParent,

Tests/FoundationEssentialsTests/ProgressManager/ProgressManagerTests.swift

@@ -330,6 +330,7 @@ extension Tag {
         }
     }
 
+    // MARK: Test deinit behavior
     func makeUnfinishedChild(subprogress: consuming Subprogress) async {
         let manager = subprogress.start(totalCount: 3)
         manager.complete(count: 2)
@@ -345,4 +346,31 @@ extension Tag {
         await makeUnfinishedChild(subprogress: manager.subprogress(assigningCount: 1))
         #expect(manager.fractionCompleted == 1.0)
     }
+    
+    func makeFinishedChild(subprogress: consuming Subprogress) async {
+        let manager = subprogress.start(totalCount: 2)
+        manager.complete(count: 2)
+    }
+    
+    @Test func finishedChild() async throws {
+        let manager = ProgressManager(totalCount: 2)
+        
+        manager.complete(count: 1)
+        #expect(manager.fractionCompleted == 0.5)
+        
+        await makeFinishedChild(subprogress: manager.subprogress(assigningCount: 1))
+        #expect(manager.fractionCompleted == 1.0)
+    }
+    
+    @Test func uninitializedSubprogress() async throws {
+        let manager = ProgressManager(totalCount: 2)
+        
+        manager.complete(count: 1)
+        
+        var subprogress: Subprogress? = manager.subprogress(assigningCount: 1)
+        #expect(manager.fractionCompleted == 0.5)
+        
+        subprogress = nil
+        #expect(manager.fractionCompleted == 1.0)
+    }
 }