Adopt swift-testing for AttributedString tests #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 10, 2025
* Convert CoW tests to swift-testing * Convert discontiguous tests to swift-testing * Convert index validity tests to swift-testing * Convert constraining behavior tests to swift-testing * Convert base attributed string tests to swift-testing * Fix build failure * Fix test crash
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 16, 2025
* Convert CoW tests to swift-testing * Convert discontiguous tests to swift-testing * Convert index validity tests to swift-testing * Convert constraining behavior tests to swift-testing * Convert base attributed string tests to swift-testing * Fix build failure * Fix test crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts swift-testing for all of the
AttributedStringtest suites. This paves the way for adding new capabilities to ourAttributedStringtests, such as adding exit tests to support validating all of our preconditions related to index validation (I'll post a followup PR that adds these new tests as I've noticed that when adding the tests, we have quite a few behavioral bugs that we should fix when adding these tests.