Skip to content

FoundationEssentials,FoundationInternationalization: adjust for aliasing #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

FoundationEssentials,FoundationInternationalization: adjust for aliasing #1340

merged 1 commit into from
Jul 9, 2025

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jun 8, 2025

When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.

@compnerd compnerd mentioned this pull request Jun 8, 2025
Merged
itingliu
itingliu reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ICU related parts look good to me

@compnerd
Copy link
Member Author

compnerd commented Jun 23, 2025

@swift-ci please test

@compnerd compnerd requested review from itingliu and jmschonfeld June 23, 2025 19:17
@compnerd
Copy link
Member Author

compnerd commented Jul 2, 2025

Please test with following PRs:
swiftlang/swift-foundation-icu#63

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 7, 2025

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 7, 2025

Please test with following PRs:
swiftlang/swift-foundation-icu#63

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 7, 2025

This should really go in with the ICU changes IMO. This is one of the last pieces needed to start exploring building the early swift-driver on Windows.

@parkera
Copy link
Contributor

parkera commented Jul 7, 2025

@compnerd do you want to handle synchronizing the merge of these two PRs when you are ready?

@compnerd
Copy link
Member Author

compnerd commented Jul 7, 2025

@parkera thanks! yeap - I'll go ahead and synchronise these two

@compnerd compnerd mentioned this pull request Jul 7, 2025
Draft
@compnerd
FoundationEssentials,FoundationInternationalization: adjust for aliasing
d24d81f 
When enabling symbol renaming in ICU, we import the functions as an
alias. This causes the implicit nullability translation with C to
disappear. Make these conversions explicit so that we can enable symbol
renaming on non-Darwin platforms.
@compnerd
Copy link
Member Author

compnerd commented Jul 9, 2025

Cross-repo tested at https://ci-external.swift.org/job/swift-PR-windows/42872/

@compnerd
Copy link
Member Author

compnerd commented Jul 9, 2025

Please test with following PRs:
swiftlang/swift-foundation-icu#63

@swift-ci please test

@compnerd compnerd merged commit d18dcdb into swiftlang:main Jul 9, 2025
16 checks passed
@compnerd compnerd deleted the unwrapping branch July 9, 2025 15:57
This was referenced Jul 9, 2025
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkera parkera parkera approved these changes

@iCharlesHu iCharlesHu Awaiting requested review from iCharlesHu

@itingliu itingliu Awaiting requested review from itingliu

@jmschonfeld jmschonfeld Awaiting requested review from jmschonfeld

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@compnerd @parkera @jmschonfeld @itingliu