PR feedback

Author: madsodgaard

Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift

@@ -171,7 +171,7 @@ extension JNISwift2JavaGenerator {
 
       printer.print(
         """
-        // Pointer to the "self".
+        /** Pointer to the "self". */
         private final long selfPointer;
         
         /** Used to track additional state of the underlying object, e.g. if it was explicitly destroyed. */

Sources/SwiftJavaDocumentation/Documentation.docc/SupportedFeatures.md

@@ -62,11 +62,13 @@ SwiftJava's `swift-java jextract` tool automates generating Java bindings from S
 | Dictionaries: `[String: Int]`, `[K:V]`                                               | ❌        | ❌   |
 | Generic parameters in functions: `func f<T: A & B>(x: T)`                            | ❌        | ✅   |
 | Generic return values in functions: `func f<T: A & B>() -> T`                        | ❌        | ❌   |
-| `Foundation.Data`, `any Foundation.DataProtocol`                                     | ✅        | ❌   |
 | Tuples: `(Int, String)`, `(A, B, C)`                                                 | ❌        | ❌   |
 | Protocols: `protocol`                                                                | ❌        | ✅   |
+| Protocols: `protocol` with associated types                                          | ❌        | ❌   |
+| Existential parameters `f(x: any SomeProtocol) `                                     | ❌        | ✅   |
 | Existential parameters `f(x: any (A & B)) `                                          | ❌        | ✅   |
 | Existential return types `f() -> any Collection `                                    | ❌        | ❌   |
+| Foundation Data and DataProtocol: `f(x: any DataProtocol) -> Data`                   | ✅        | ❌   |
 | Opaque parameters: `func take(worker: some Builder) -> some Builder`                 | ❌        | ✅   |
 | Opaque return types: `func get() -> some Builder`                                    | ❌        | ❌   |
 | Optional parameters: `func f(i: Int?, class: MyClass?)`                              | ✅        | ✅   |
@@ -272,9 +274,11 @@ try (var arena = SwiftArena.ofConfined()) {
 
 ### Protocols
 
-> Note: Protocols are currently only supported in JNI mode.
+> Note: Protocols are currently only supported in JNI mode. 
+>
+> With the exception of `any DataProtocol` which is handled as `Foundation.Data` in the FFM mode.
 
-Protocols are imported as Java `interface`s. For now, we require that all
+Swift `protocol` types are imported as Java `interface`s. For now, we require that all
 concrete types of an interface wrap a Swift instance. In the future, we will add support
 for providing Java-based implementations of interfaces, that you can pass to Java functions.
 
@@ -305,6 +309,10 @@ will be exported as
 ```java
 <S extends A & B, T1 extends C, T2 extends D> void f(S x, T1 y, T2 z)   
 ```
+On the Java side, only SwiftInstance implementing types may be passed; 
+so this isn't a way for compatibility with just any arbitrary Java interfaces, 
+but specifically, for allowing passing concrete binding types generated by jextract from Swift types
+which conform a to a given Swift protocol.
 
-#### Return types
+#### Returning protocol types
 Protocols are not yet supported as return types.