PR feedback

Author: madsodgaard

Samples/SwiftKitSampleApp/Sources/MySwiftLibrary/MySwiftClass.swift

@@ -14,6 +14,7 @@
 
 public class MySwiftClass {
 
+  public let byte: UInt8 = 0
   public var len: Int
   public var cap: Int
 

Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift

@@ -176,7 +176,7 @@ extension JNISwift2JavaGenerator {
   }
 
   private func printFunctionBinding(_ printer: inout CodePrinter, _ decl: ImportedFunc) {
-    guard let translatedDecl = translatedDecl(for: decl) else {
+    guard let _ = translatedDecl(for: decl) else {
       // Failed to translate. Skip.
       return
     }
@@ -201,7 +201,7 @@ extension JNISwift2JavaGenerator {
   /// and passes it down to another native function along with the arguments
   /// to call the Swift implementation.
   private func printMemberMethodBindings(_ printer: inout CodePrinter, _ decl: ImportedFunc) {
-    let translatedDecl = translatedDecl(for: decl)!
+    let translatedDecl = translatedDecl(for: decl)! // We will only call this method if we can translate the decl.
 
     printDeclDocumentation(&printer, decl)
     printer.printBraceBlock("public \(renderFunctionSignature(decl))") { printer in
@@ -283,7 +283,9 @@ extension JNISwift2JavaGenerator {
   /// `func method(x: Int, y: Int) -> Int` becomes
   /// `long method(long x, long y)`
   private func renderFunctionSignature(_ decl: ImportedFunc) -> String {
-    let translatedDecl = translatedDecl(for: decl)!
+    guard let translatedDecl = translatedDecl(for: decl) else {
+      fatalError("Unable to render function signature for a function that cannot be translated: \(decl)")
+    }
     let resultType = translatedDecl.translatedFunctionSignature.resultType
     var parameters = translatedDecl.translatedFunctionSignature.parameters.map(\.asParameter)
 

Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift

@@ -27,7 +27,7 @@ extension JNISwift2JavaGenerator {
       let translation = JavaTranslation(swiftModuleName: swiftModuleName)
       translated = try translation.translate(decl)
     } catch {
-      self.logger.info("Failed to translate: '\(decl.swiftDecl.qualifiedNameForDebug)'; \(error)")
+      self.logger.debug("Failed to translate: '\(decl.swiftDecl.qualifiedNameForDebug)'; \(error)")
       translated = nil
     }
 

Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift

@@ -164,7 +164,7 @@ extension JNISwift2JavaGenerator {
   }
 
   private func printSwiftStaticFunctionThunk(_ printer: inout CodePrinter, _ decl: ImportedFunc) {
-    let translatedDecl = self.translatedDecl(for: decl)!
+    let translatedDecl = self.translatedDecl(for: decl)! // We will only call this method if we can translate the decl.
 
     printCDecl(
       &printer,
@@ -181,7 +181,7 @@ extension JNISwift2JavaGenerator {
   }
 
   private func printSwiftMemberFunctionThunk(_ printer: inout CodePrinter, _ decl: ImportedFunc) {
-    let translatedDecl = self.translatedDecl(for: decl)!
+    let translatedDecl = self.translatedDecl(for: decl)! // We will only call this method if can translate the decl.
     let swiftParentName = decl.parentType!.asNominalTypeDeclaration!.qualifiedName
 
     printCDecl(
@@ -208,7 +208,9 @@ extension JNISwift2JavaGenerator {
     _ decl: ImportedFunc,
     calleeName: String
   ) {
-    let translatedDecl = self.translatedDecl(for: decl)!
+    guard let translatedDecl = self.translatedDecl(for: decl) else {
+      fatalError("Cannot print function downcall for a function that can't be translated: \(decl)")
+    }
     let swiftReturnType = decl.functionSignature.result.type
 
     let tryClause: String = decl.isThrowing ? "try " : ""