Java2Swift: Java static methods need to use "public", not "open"

Author: DougGregor

Sources/Java2SwiftLib/JavaClassTranslator.swift

@@ -523,7 +523,8 @@ extension JavaClassTranslator {
       ? ""
       : javaMethod.isStatic ? "@JavaStaticMethod\n" : "@JavaMethod\n";
     let accessModifier = implementedInSwift ? ""
-      : "\(translator.defaultAccessSpecifier) "
+      : (javaMethod.isStatic || !translator.translateAsClass) ? "public "
+      : "open "
     let overrideOpt = (translator.translateAsClass &&
                        !javaMethod.isStatic && isOverride(javaMethod))
       ? "override "

Sources/Java2SwiftLib/JavaTranslator.swift

@@ -250,11 +250,6 @@ extension JavaTranslator {
 
     throw TranslationError.untranslatedJavaClass(name)
   }
-
-  /// The default Swift access specifier for a Java method.
-  var defaultAccessSpecifier: String {
-    translateAsClass ? "open" : "public"
-  }
 }
 
 // MARK: Class translation

Tests/Java2SwiftTests/Java2SwiftTests.swift

@@ -323,7 +323,11 @@ class Java2SwiftTests: XCTestCase {
         """
           @JavaMethod
           open func intern() -> String
+        """,
         """
+          @JavaStaticMethod
+          public func valueOf(_ arg0: Int64) -> String
+        """,
       ]
     )
   }