rename cleanup create function to $ func as well

Author: ktoso

SwiftKitCore/src/main/java/org/swift/swiftkit/core/ConfinedSwiftMemorySession.java

@@ -60,7 +60,7 @@ public void close() {
     public void register(SwiftInstance instance) {
         checkValid();
 
-        SwiftInstanceCleanup cleanup = instance.createCleanupAction();
+        SwiftInstanceCleanup cleanup = instance.$createCleanup();
         this.resources.add(cleanup);
     }
 

SwiftKitCore/src/main/java/org/swift/swiftkit/core/SwiftInstance.java

@@ -41,11 +41,7 @@ protected SwiftInstance(SwiftArena arena) {
      * <p/>
      * <b>Warning:</b> The cleanup action must not capture {@code this}.
      */
-    public abstract SwiftInstanceCleanup createCleanupAction();
-
-    // TODO: make this a flagset integer and/or use a field updater
-    /** Used to track additional state of the underlying object, e.g. if it was explicitly destroyed. */
-    private final AtomicBoolean $state$destroyed = new AtomicBoolean(false);
+    public abstract SwiftInstanceCleanup $createCleanup();
 
     /**
      * Exposes a boolean value which can be used to indicate if the object was destroyed.

SwiftKitFFM/src/main/java/org/swift/swiftkit/ffm/AllocatingAutoSwiftMemorySession.java

@@ -56,7 +56,7 @@ public void register(SwiftInstance instance) {
 
         // We make sure we don't capture `instance` in the
         // cleanup action, so we can ignore the warning below.
-        var cleanupAction = instance.createCleanupAction();
+        var cleanupAction = instance.$createCleanup();
         cleaner.register(instance, cleanupAction);
     }
 

SwiftKitFFM/src/main/java/org/swift/swiftkit/ffm/FFMSwiftInstance.java

@@ -52,7 +52,7 @@ protected FFMSwiftInstance(MemorySegment segment, AllocatingSwiftArena arena) {
 
 
     @Override
-    public SwiftInstanceCleanup createCleanupAction() {
+    public SwiftInstanceCleanup $createCleanup() {
         var statusDestroyedFlag = $statusDestroyedFlag();
         Runnable markAsDestroyed = () -> statusDestroyedFlag.set(true);