Drop the "canonicalClassName" from JavaTypes because it is now incorrect

We're using the "normal" name now that uses $ for nested classes.

Author: DougGregor

Sources/JavaKit/Optional+JavaObject.swift

@@ -37,7 +37,7 @@ extension Optional: JavaValue where Wrapped: AnyJavaObject {
   }
 
   public static var javaType: JavaType {
-    JavaType(canonicalClassName: Wrapped.fullJavaClassName)
+    JavaType(className: Wrapped.fullJavaClassName)
   }
 
   public static func jniMethodCall(

Sources/JavaTypes/JavaType+JavaSource.swift

@@ -32,7 +32,7 @@ extension JavaType {
       self = try JavaType(mangledName: name)
 
     case let className:
-      self = JavaType(canonicalClassName: className)
+      self = JavaType(className: className)
     }
   }
 }

Sources/JavaTypes/JavaType.swift

@@ -31,9 +31,9 @@ public enum JavaType: Equatable, Hashable {
   /// A Java array.
   indirect case array(JavaType)
 
-  /// Given a canonical class name such as "java.lang.Object", split it into
+  /// Given a class name such as "java.lang.Object", split it into
   /// its package and class name to form a class instance.
-  public init(canonicalClassName name: some StringProtocol) {
+  public init(className name: some StringProtocol) {
     if let lastDot = name.lastIndex(of: ".") {
       self = .class(
         package: String(name[..<lastDot]),

Sources/JavaTypes/Mangling.swift

@@ -125,7 +125,7 @@ extension JavaType {
       string = string[string.index(after: semicolonIndex)...]
 
       return JavaType(
-        canonicalClassName: canonicalNameWithSlashes.replacingSlashesWithPeriods()
+        className: canonicalNameWithSlashes.replacingSlashesWithPeriods()
       )
 
     default: