Skip to content

Commit 9571cd4

Browse files
authored
Merge pull request #960 from cwakamo/eng/issue-958-call-ExtActionCache-callback-on-cache-miss
[llbuild3] Fix an issue which caused action cache misses to prevent builds from completing. The ExtActionCache implementation for the TActionCache protocol failed to call the callback on a cache miss. This meant that cache misses, as are the case in fully-clean builds, would never allow the build to proceed to any actual work. This commit resolves #958.
2 parents d65e3eb + 4419611 commit 9571cd4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/llbuild3/core/ActionCache.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ extension TActionCache {
4444
let bytes = try value.serializedData()
4545
handler(std.string(fromData: bytes), std.string())
4646
return
47+
} else {
48+
handler(std.string(), std.string())
49+
return
4750
}
4851
} catch {
4952
let err: TError

0 commit comments

Comments
 (0)