Revert "use Win32 file APIs and widePath for file ops to support long filenames" #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
dmbryson,
jakepetroules and
owenv
as code owners
|
@swift-ci please test |
|
https://ci-external.swift.org/job/swift-PR-windows/44372/ is the swift cross-pr testing run. Though I'm not sure how they could be different 🤔 |
|
Going to merge this to unblock CI. Note that from what I can see in the logs, the PR testing in the original job didn't actually test the change: Will look into that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1004. Possibly the cause of Windows CI failures, will run cross PR testing to check.