Skip to content

Commit 34f7817

Browse files
ktosoa7medevhamishknight
authored
Apply suggestions from code review
Co-authored-by: Ahmed Elrefaey <[email protected]> Co-authored-by: Hamish Knight <[email protected]>
1 parent e9afb04 commit 34f7817

4 files changed

+6
-6
lines changed

_data/authors.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ mitchellallison:
555555
mads:
556556
name: Mads Odgaard
557557
558-
github: https://github.com/madsodgaard
558+
github: madsodgaard
559559
about: Mads is a Google Summer of Code 2025 contributor, where he worked on bringing JNI support to the jextract tool which is part of the Swift Java interoperability project.
560560

561561
ahmedelrefaey:

_posts/2025-11-NN-swift-gsoc-2024-highlight-1-vscode-swiftly.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ I have linked all pull requests and technical details in my **[detailed project
9393

9494
This GSoC experience has been transformative. I came in as someone intimidated by large codebases, and I'm leaving with the confidence to tackle complex, multi-tool integrations. I'm excited to continue contributing to Swift community!
9595

96-
Thank you.
9796

9897
---
9998

_posts/2025-11-NN-swift-gsoc-2024-highlight-2-swift-java-jextract-jni-mode.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ This concept also exists in the FFM mode, and I recommend watching Konrad’s ta
111111
112112
If we take a look at the native implementation of `$init` in Swift, we see how we allocate and initialize the memory:
113113
```swift
114+
// Generated code, not something you would write
115+
114116
@_cdecl("Java_com_example_swift_MySwiftClass__00024init__JJ")
115117
func Java_com_example_swift_MySwiftClass__00024init__JJ(environment: UnsafeMutablePointer<JNIEnv?>!, thisClass: jclass, x: jlong, y: jlong) -> jlong {
116118
let result$ = UnsafeMutablePointer<MySwiftClass>.allocate(capacity: 1)

_posts/2025-11-NN-swift-gsoc-2024-highlight-3-vscode-swift-lsp-documentation.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,10 @@ This is Ahmed Elrefaey, I’m excited to share with you an update on my GSoC pro
3131

3232
The aim of this project is to enhance how documentation is displayed in SourceKit-LSP during code completion by:
3333

34-
1. Showing the full documentation for a code completion item instead of the first paragraph only which we call “brief documentation”.
34+
1. Showing the full documentation for a code completion item instead of the first paragraph only, which we call “brief documentation”.
35+
2. Implementing Language Server Protocol’s [signature help](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp) request showing the user which overloads are available, along with their corresponding documentation.
3536

36-
2. Implementing Language Server Protocol’s [signature help](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp) request showing the user which overloads are available along with their corresponding documentation.
37-
38-
### Progress**
37+
### Progress
3938

4039
During this summer, we have made great progress on this project that I want to share with you.
4140

0 commit comments

Comments
 (0)