Remove line breaks from long WinGet command #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WinGet command for installing Windows platform dependencies contained line breaks. When copied, the line breaks would break the command up in to multiple lines. The first line is a valid command and so runs sucessfully but the subsequent lines are truncated and will produce an error if run. Update the command to remove line breaks, and update the css for `.code-box pre code`` to add back in line breaks in css that are not preserved when the command is copied. The swiftly install command breaks the command up with backslashes `\` but on Windows we would have to either use `^` for cmd.exe or backtick for powershell. This ambiguity means its safer just to put the whole command on one line.
plemarquand
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
shahmishal
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WinGet command for installing Windows platform dependencies contained line breaks. When copied, the line breaks would break the command up in to multiple lines. The first line is a valid command and so runs sucessfully but the subsequent lines are truncated and will produce an error if run.
Update the command to remove line breaks, and update the css for
.code-box pre codeto add back in line breaks in css that are not preserved when the command is copied.The swiftly install command breaks the command up with backslashes
\but on Windows we would have to either use^for cmd.exe or backtick for powershell. This ambiguity means its safer just to put the whole command on one line.