Fix code block tabs on mobile #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandersandberg
requested review from
0xTim,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
shahmishal
approved these changes
Jun 4, 2025
jesseaborden
reviewed
Jun 4, 2025
|
|
||
| ul { | ||
| white-space: nowrap; | ||
| width: calc(100% - 59px); |
Contributor
There was a problem hiding this comment.
Hey @alexandersandberg, The intent here was to extend the tab nav to the edge of the container, so it was clear that the element was scrollable. The 59px accounts for half the horizontal padding. It's definitely a bit of a magic number right now, so maybe we can rework that or add a comment to make it more clear. I do see that the last item isn't scrolling correctly. Adding some padding to the last item or edge of the container may correct that.
Member
Author
There was a problem hiding this comment.
I see! I think it would be good to avoid the magic numbers though as they're likely to break sooner or later. I will see if I can figure out a way around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken code block tabs.
Motivation:
The code block tabs don't work properly on mobile:
Modifications:
Result:
Install page
CLI tools page