Fix "Copy install command" button on old releases page #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromy
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
shahmishal
approved these changes
Jul 10, 2025
heckj
approved these changes
Jul 10, 2025
Member
heckj
left a comment
heckj
left a comment
There was a problem hiding this comment.
Verified with a locally run version as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two definitions of
copyToClipboardin the codebase, one with one argand one with two args. The onClick handler ends up calling the wrong one for a
number of links. I assume the issue is something like:
Attempt to fix this by instead using the two arg version and removing the one arg version.
However I do not have a Ruby environment setup to test with so I haven't been able to try it.
This resolves #1108.