Build: make some of the private API more public

This extends the visibility of some of the private implementation to the
package level to allow use for testing without `@testable` imports.

Author: compnerd

Sources/Build/BuildDescription/ClangModuleBuildDescription.swift

@@ -128,7 +128,7 @@ public final class ClangModuleBuildDescription {
     public let buildToolPluginInvocationResults: [BuildToolPluginInvocationResult]
 
     /// Create a new target description with target and build parameters.
-    init(
+    package init(
         package: ResolvedPackage,
         target: ResolvedModule,
         toolsVersion: ToolsVersion,

Sources/Build/BuildDescription/ModuleBuildDescription.swift

@@ -122,7 +122,7 @@ public enum ModuleBuildDescription: SPMBuildCore.ModuleBuildDescription {
         }
     }
 
-    var destination: BuildParameters.Destination {
+    package var destination: BuildParameters.Destination {
         switch self {
         case .swift(let buildDescription):
             buildDescription.destination
@@ -162,6 +162,11 @@ extension ModuleBuildDescription: Identifiable {
     public struct ID: Hashable {
         let moduleID: ResolvedModule.ID
         let destination: BuildParameters.Destination
+
+        package init(moduleID: ResolvedModule.ID, destination: BuildParameters.Destination) {
+            self.moduleID = moduleID
+            self.destination = destination
+        }
     }
 
     public var id: ID {

Sources/Build/BuildDescription/ProductBuildDescription.swift

@@ -50,7 +50,7 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
 
     /// The dynamic libraries this product needs to link with.
     // Computed during build planning.
-    var dylibs: [ProductBuildDescription] = []
+    package var dylibs: [ProductBuildDescription] = []
 
     /// Any additional flags to be added. These flags are expected to be computed during build planning.
     var additionalFlags: [String] = []
@@ -65,7 +65,7 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
     var libraryBinaryPaths: Set<AbsolutePath> = []
 
     /// Paths to tools shipped in binary dependencies
-    var availableTools: [String: AbsolutePath] = [:]
+    package var availableTools: [String: AbsolutePath] = [:]
 
     /// Path to the temporary directory for this product.
     var tempsPath: AbsolutePath {
@@ -85,7 +85,7 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
     private let observabilityScope: ObservabilityScope
 
     /// Create a build description for a product.
-    init(
+    package init(
         package: ResolvedPackage,
         product: ResolvedProduct,
         toolsVersion: ToolsVersion,
@@ -422,6 +422,11 @@ extension ProductBuildDescription: Identifiable {
     public struct ID: Hashable {
         let productID: ResolvedProduct.ID
         let destination: BuildParameters.Destination
+
+        package init(productID: ResolvedProduct.ID, destination: BuildParameters.Destination) {
+            self.productID = productID
+            self.destination = destination
+        }
     }
 
     public var id: ID {

Sources/Build/BuildDescription/SwiftModuleBuildDescription.swift

@@ -169,7 +169,7 @@ public final class SwiftModuleBuildDescription {
     var libraryBinaryPaths: Set<AbsolutePath> = []
 
     /// Any addition flags to be added. These flags are expected to be computed during build planning.
-    var additionalFlags: [String] = []
+    package var additionalFlags: [String] = []
 
     /// Describes the purpose of a test target, including any special roles such as containing a list of discovered
     /// tests or serving as the manifest target which contains the main entry point.
@@ -808,7 +808,7 @@ public final class SwiftModuleBuildDescription {
         self.target.type == .library
     }
 
-    func writeOutputFileMap(to path: AbsolutePath) throws {
+    package func writeOutputFileMap(to path: AbsolutePath) throws {
         let masterDepsPath = self.tempsPath.appending("master.swiftdeps")
 
         var content =

Sources/Build/BuildManifest/LLBuildManifestBuilder+Product.swift

@@ -20,7 +20,7 @@ import struct PackageGraph.ResolvedModule
 import struct PackageGraph.ResolvedProduct
 
 extension LLBuildManifestBuilder {
-    func createProductCommand(_ buildProduct: ProductBuildDescription) throws {
+    package func createProductCommand(_ buildProduct: ProductBuildDescription) throws {
         let cmdName = try buildProduct.commandName
 
         // Add dependency on Info.plist generation on Darwin platforms.

Sources/Build/BuildManifest/LLBuildManifestBuilder.swift

@@ -65,7 +65,7 @@ public class LLBuildManifestBuilder {
     public internal(set) var manifest: LLBuildManifest = .init()
 
     /// Mapping from Swift compiler path to Swift get version files.
-    var swiftGetVersionFiles = [AbsolutePath: AbsolutePath]()
+    package var swiftGetVersionFiles = [AbsolutePath: AbsolutePath]()
 
     /// Create a new builder with a build plan.
     public init(

Sources/Build/BuildOperation.swift

@@ -577,7 +577,7 @@ public final class BuildOperation: PackageStructureDelegate, SPMBuildCore.BuildS
     }
 
     /// Compute the llbuild target name using the given subset.
-    func computeLLBuildTargetName(for subset: BuildSubset) async throws -> String {
+    package func computeLLBuildTargetName(for subset: BuildSubset) async throws -> String {
         func inferTestDestination(
             testModule: ResolvedModule,
             graph: ModulesGraph
@@ -1023,7 +1023,7 @@ extension BuildDescription {
 }
 
 extension BuildSubset {
-    func recursiveDependencies(for graph: ModulesGraph, observabilityScope: ObservabilityScope) throws -> [ResolvedModule]? {
+    package func recursiveDependencies(for graph: ModulesGraph, observabilityScope: ObservabilityScope) throws -> [ResolvedModule]? {
         switch self {
         case .allIncludingTests:
             return Array(graph.reachableModules)

Sources/Build/BuildPlan/BuildPlan.swift

@@ -785,7 +785,7 @@ extension BuildPlan {
     ///
     /// Note that warnings emitted by the the plugin itself will be returned in the `BuildToolPluginInvocationResult`
     /// structures for later showing to the user, and not added directly to the diagnostics engine.
-    static func invokeBuildToolPlugins(
+    package static func invokeBuildToolPlugins(
         for module: ResolvedModule,
         destination: BuildParameters.Destination,
         configuration: PluginConfiguration,