PackageRegistry: make some of the private API more public

This extends the visibility of some of the private implementation to the
package level to allow use for testing without `@testable` imports.

Author: compnerd

Sources/PackageRegistry/ChecksumTOFU.swift

@@ -20,13 +20,13 @@ import Foundation
 
 import struct TSCUtility.Version
 
-struct PackageVersionChecksumTOFU {
+package struct PackageVersionChecksumTOFU {
     private let fingerprintStorage: PackageFingerprintStorage?
     private let fingerprintCheckingMode: FingerprintCheckingMode
     private let versionMetadataProvider: (PackageIdentity.RegistryIdentity, Version) async throws -> RegistryClient
         .PackageVersionMetadata
 
-    init(
+    package init(
         fingerprintStorage: PackageFingerprintStorage?,
         fingerprintCheckingMode: FingerprintCheckingMode,
         versionMetadataProvider: @escaping (PackageIdentity.RegistryIdentity, Version) async throws -> RegistryClient
@@ -38,7 +38,7 @@ struct PackageVersionChecksumTOFU {
     }
 
     // MARK: - source archive
-    func validateSourceArchive(
+    package func validateSourceArchive(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,
         version: Version,
@@ -139,7 +139,7 @@ struct PackageVersionChecksumTOFU {
         return checksum
     }
 
-    func validateManifest(
+    package func validateManifest(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,
         version: Version,

Sources/PackageRegistry/RegistryClient.swift

@@ -1337,7 +1337,7 @@ public final class RegistryClient: AsyncCancellable {
     }
 
     @available(*, deprecated, message: "Use the async alternative")
-    func checkAvailability(
+    package func checkAvailability(
         registry: Registry,
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
@@ -1354,7 +1354,7 @@ public final class RegistryClient: AsyncCancellable {
     }
 
     // marked internal for testing
-    func checkAvailability(
+    package func checkAvailability(
         registry: Registry,
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope
@@ -1818,7 +1818,7 @@ extension RegistryClient {
         case error(String)
 
         // marked internal for testing
-        static var unavailableStatusCodes = [404, 501]
+        package static var unavailableStatusCodes = [404, 501]
     }
 }
 

Sources/PackageRegistry/RegistryConfiguration.swift

@@ -145,7 +145,7 @@ extension RegistryConfiguration {
         }
 
         // for testing
-        init(
+        package init(
             default: Global,
             registryOverrides: [String: RegistryOverride] = [:],
             scopeOverrides: [PackageIdentity.Scope: ScopePackageOverride] = [:],
@@ -165,7 +165,7 @@ extension RegistryConfiguration {
             }
 
             // for testing
-            init(signing: Signing) {
+            package init(signing: Signing) {
                 self.signing = signing
             }
         }

Sources/PackageRegistry/RegistryDownloadsManager.swift

@@ -365,6 +365,11 @@ extension RegistryDownloadsManager {
         public let fromCache: Bool
         /// Indicates whether the repository was already present in the cache and updated or if a clean fetch was performed.
         public let updatedCache: Bool
+
+        package init(fromCache: Bool, updatedCache: Bool) {
+            self.fromCache = fromCache
+            self.updatedCache = updatedCache
+        }
     }
 }
 
@@ -385,7 +390,7 @@ extension PackageIdentity {
         return try RelativePath(validating: registryIdentity.scope.description).appending(component: registryIdentity.name.description)
     }
 
-    internal func downloadPath(version: Version) throws -> Basics.RelativePath {
+    package func downloadPath(version: Version) throws -> Basics.RelativePath {
         try self.downloadPath().appending(component: version.description)
     }
 }

Sources/PackageRegistry/SignatureValidation.swift

@@ -22,13 +22,13 @@ import TSCBasic
 
 import struct TSCUtility.Version
 
-protocol SignatureValidationDelegate {
+package protocol SignatureValidationDelegate {
     func onUnsigned(registry: Registry, package: PackageIdentity, version: Version, completion: (Bool) -> Void)
     func onUntrusted(registry: Registry, package: PackageIdentity, version: Version, completion: (Bool) -> Void)
 }
 
-struct SignatureValidation {
-    typealias Delegate = SignatureValidationDelegate
+package struct SignatureValidation {
+    package typealias Delegate = SignatureValidationDelegate
 
     private let skipSignatureValidation: Bool
     private let signingEntityTOFU: PackageSigningEntityTOFU
@@ -40,7 +40,7 @@ struct SignatureValidation {
         case passthrough(Error)
     }
 
-    init(
+    package init(
         skipSignatureValidation: Bool,
         signingEntityStorage: PackageSigningEntityStorage?,
         signingEntityCheckingMode: SigningEntityCheckingMode,
@@ -58,7 +58,7 @@ struct SignatureValidation {
     }
 
     // MARK: - source archive
-    func validate(
+    package func validate(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,
         version: Version,
@@ -313,7 +313,7 @@ struct SignatureValidation {
     }
 
     // MARK: - manifests
-    func validate(
+    package func validate(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,
         version: Version,

Sources/PackageRegistry/SigningEntityTOFU.swift

@@ -19,11 +19,11 @@ import PackageSigning
 
 import struct TSCUtility.Version
 
-struct PackageSigningEntityTOFU {
+package struct PackageSigningEntityTOFU {
     private let signingEntityStorage: PackageSigningEntityStorage?
     private let signingEntityCheckingMode: SigningEntityCheckingMode
 
-    init(
+    package init(
         signingEntityStorage: PackageSigningEntityStorage?,
         signingEntityCheckingMode: SigningEntityCheckingMode
     ) {