Mark completion callbacks as Sendable (#8712)

Many of the completion callbacks used in the legacy sync versions of
async functions were not marked as Sendable. This produced a warning
when they were provided to `DispatchQueue.asyncResult`, which expects a
Sendable callback.

Author: plemarquand

Sources/PackageGraph/PackageContainer.swift

@@ -204,7 +204,7 @@ public protocol PackageContainerProvider {
         updateStrategy: ContainerUpdateStrategy,
         observabilityScope: ObservabilityScope,
         on queue: DispatchQueue,
-        completion: @escaping (Result<PackageContainer, Error>) -> Void
+        completion: @escaping @Sendable (Result<PackageContainer, Error>) -> Void
     )
 }
 

Sources/PackageRegistry/ChecksumTOFU.swift

@@ -76,7 +76,7 @@ struct PackageVersionChecksumTOFU {
         timeout: DispatchTimeInterval?,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<Void, Error>) -> Void
+        completion: @escaping @Sendable (Result<Void, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.validateSourceArchive(

Sources/PackageRegistry/RegistryClient.swift

@@ -217,7 +217,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<PackageMetadata, Error>) -> Void
+        completion: @escaping @Sendable (Result<PackageMetadata, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.getPackageMetadata(
@@ -377,7 +377,7 @@ public final class RegistryClient: AsyncCancellable {
         fileSystem: FileSystem,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<PackageVersionMetadata, Error>) -> Void
+        completion: @escaping @Sendable (Result<PackageVersionMetadata, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.getPackageVersionMetadata(
@@ -620,7 +620,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<[String: (toolsVersion: ToolsVersion, content: String?)], Error>) -> Void
+        completion: @escaping @Sendable (Result<[String: (toolsVersion: ToolsVersion, content: String?)], Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.getAvailableManifests(
@@ -775,7 +775,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<String, Error>) -> Void
+        completion: @escaping @Sendable (Result<String, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.getManifestContent(
@@ -997,7 +997,7 @@ public final class RegistryClient: AsyncCancellable {
         fileSystem: FileSystem,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<Void, Error>) -> Void
+        completion: @escaping @Sendable (Result<Void, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.downloadSourceArchive(
@@ -1084,7 +1084,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<Set<PackageIdentity>, Error>) -> Void
+        completion: @escaping @Sendable (Result<Set<PackageIdentity>, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.lookupIdentities(
@@ -1133,7 +1133,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<Void, Error>) -> Void
+        completion: @escaping @Sendable (Result<Void, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.login(
@@ -1158,7 +1158,7 @@ public final class RegistryClient: AsyncCancellable {
         fileSystem: FileSystem,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<PublishResult, Error>) -> Void
+        completion: @escaping @Sendable (Result<PublishResult, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.publish(
@@ -1342,7 +1342,7 @@ public final class RegistryClient: AsyncCancellable {
         timeout: DispatchTimeInterval? = .none,
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<AvailabilityStatus, Error>) -> Void
+        completion: @escaping @Sendable (Result<AvailabilityStatus, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.checkAvailability(

Sources/PackageRegistry/RegistryDownloadsManager.swift

@@ -128,7 +128,7 @@ public class RegistryDownloadsManager: AsyncCancellable {
         observabilityScope: ObservabilityScope,
         delegateQueue: DispatchQueue,
         callbackQueue: DispatchQueue,
-        completion: @escaping (Result<Basics.AbsolutePath, Error>) -> Void
+        completion: @escaping @Sendable (Result<Basics.AbsolutePath, Error>) -> Void
     ) {
         callbackQueue.asyncResult(completion) {
             try await self.lookup(

Sources/PackageRegistry/SigningEntityTOFU.swift

@@ -83,7 +83,7 @@ struct PackageSigningEntityTOFU {
         version: Version,
         signingEntity: SigningEntity?,
         observabilityScope: ObservabilityScope,
-        completion: @escaping (Result<Void, Error>) -> Void
+        completion: @escaping @Sendable (Result<Void, Error>) -> Void
     ) {
         DispatchQueue.sharedConcurrent.asyncResult(completion) {
             try await self.validate(

Sources/Workspace/Workspace.swift

@@ -1077,7 +1077,7 @@ extension Workspace {
     public func loadRootManifests(
         packages: [AbsolutePath],
         observabilityScope: ObservabilityScope,
-        completion: @escaping (Result<[AbsolutePath: Manifest], Error>) -> Void
+        completion: @escaping @Sendable (Result<[AbsolutePath: Manifest], Error>) -> Void
     ) {
         DispatchQueue.sharedConcurrent.asyncResult(completion) {
             try await self.loadRootManifests(
@@ -1266,7 +1266,7 @@ extension Workspace {
         with identity: PackageIdentity,
         packageGraph: ModulesGraph,
         observabilityScope: ObservabilityScope,
-        completion: @escaping (Result<Package, Error>) -> Void
+        completion: @escaping @Sendable (Result<Package, Error>) -> Void
     ) {
         DispatchQueue.sharedConcurrent.asyncResult(completion) {
             try await self.loadPackage(