[Commands] AddSetting: Searching for a target in the manifest shouldn… (#8699)

…'t walk targets recursively

### Motivation:

Otherwise in situations like:

```swift
let package = Package(
  name: "packages",
  targets: [
    .target(
      name: "MyTest",
      dependencies: [
        .byName(name: "Dependency")
      ]
    ),
    .target(
      name: "Dependency"
    )
  ]
)
```

When adding settings to `Dependency` we'd find `.byName(name:
"Dependency")`
instead of `.target(name: "Dependency", ...)`.

### Modifications:

- Replace use of `findFirst` in `AddSwiftSetting.addToTarget` with a
custom walk over the targets array.

### Result:

Find correct element in the manifest "targets" array.

Author: xedin

Sources/Commands/PackageCommands/Migrate.swift

@@ -214,7 +214,8 @@ extension SwiftPackageCommand {
                 try SwiftPackageCommand.AddSetting.editSwiftSettings(
                     of: target,
                     using: swiftCommandState,
-                    settings
+                    settings,
+                    verbose: !self.globalOptions.logging.quiet
                 )
             } catch {
                 swiftCommandState.observabilityScope.emit(error: "Could not update manifest for '\(target)' (\(error)). Please enable '\(features.map(\.name).joined(separator: ", "))' features manually.")

Sources/PackageModelSyntax/AddSwiftSetting.swift

@@ -99,15 +99,23 @@ public enum AddSwiftSetting {
             throw ManifestEditError.cannotFindTargets
         }
 
-        guard let targetCall = FunctionCallExprSyntax.findFirst(in: targetArray, matching: {
-            if let nameArgument = $0.findArgument(labeled: "name"),
-               let nameLiteral = nameArgument.expression.as(StringLiteralExprSyntax.self),
-               nameLiteral.representedLiteralValue == target
-            {
-                return true
+        let targetCall = targetArray
+            .elements
+            .lazy
+            .compactMap {
+                $0.expression.as(FunctionCallExprSyntax.self)
+            }.first { targetCall in
+                if let nameArgument = targetCall.findArgument(labeled: "name"),
+                   let nameLiteral = nameArgument.expression.as(StringLiteralExprSyntax.self),
+                   nameLiteral.representedLiteralValue == target
+                {
+                    return true
+                }
+
+                return false
             }
-            return false
-        }) else {
+
+        guard let targetCall else {
             throw ManifestEditError.cannotFindTarget(targetName: target)
         }
 

Tests/PackageModelSyntaxTests/ManifestEditTests.swift

@@ -873,6 +873,50 @@ class ManifestEditTests: XCTestCase {
                 manifest: manifest
             )
         }
+
+        try assertManifestRefactor("""
+            // swift-tools-version: 5.8
+            let package = Package(
+                name: "packages",
+                targets: [
+                    .target(
+                        name: "MyTest",
+                        dependencies: [
+                            .byName(name: "Dependency")
+                        ]
+                    ),
+                    .target(
+                        name: "Dependency"
+                    )
+                ]
+            )
+            """,
+            expectedManifest: """
+            // swift-tools-version: 5.8
+            let package = Package(
+                name: "packages",
+                targets: [
+                    .target(
+                        name: "MyTest",
+                        dependencies: [
+                            .byName(name: "Dependency")
+                        ]
+                    ),
+                    .target(
+                        name: "Dependency",
+                        swiftSettings: [
+                            .enableUpcomingFeature("ExistentialAny"),
+                        ]
+                    )
+                ]
+            )
+            """) { manifest in
+            try AddSwiftSetting.upcomingFeature(
+                to: "Dependency",
+                name: "ExistentialAny",
+                manifest: manifest
+            )
+        }
     }
 }
 /// Assert that applying the moveSingleTargetSources operation to the manifest