[Swift Build] Default to the package's declared deployment target if none is explicitly specified

Author: owenv

Fixtures/Miscellaneous/RequiresOlderDeploymentTarget/Foo.swift

@@ -0,0 +1,8 @@
+@available(macOS, obsoleted: 13.0)
+func foo() {
+
+}
+
+func bar() {
+    foo()
+}

Fixtures/Miscellaneous/RequiresOlderDeploymentTarget/Package.swift

@@ -0,0 +1,13 @@
+// swift-tools-version:6.1
+import PackageDescription
+
+let package = Package(
+    name: "Foo",
+    platforms: [.macOS(.v12)],
+    products: [
+        .library(name: "Foo", targets: ["Foo"]),
+    ],
+    targets: [
+        .target(name: "Foo", path: "./"),
+    ]
+)

Sources/Basics/Triple+Basics.swift

@@ -85,7 +85,16 @@ extension Triple {
     }
 
     /// Determine the versioned host triple using the Swift compiler.
-    public static func getHostTriple(usingSwiftCompiler swiftCompiler: AbsolutePath) throws -> Triple {
+    public static func getVersionedHostTriple(usingSwiftCompiler swiftCompiler: AbsolutePath) throws -> Triple {
+        try Self.getHostTriple(usingSwiftCompiler: swiftCompiler, versioned: true)
+    }
+
+    /// Determine the unversioned host triple using the Swift compiler.
+    public static func getUnversionedHostTriple(usingSwiftCompiler swiftCompiler: AbsolutePath) throws -> Triple {
+        try Self.getHostTriple(usingSwiftCompiler: swiftCompiler, versioned: false)
+    }
+
+    private static func getHostTriple(usingSwiftCompiler swiftCompiler: AbsolutePath, versioned: Bool) throws -> Triple {
         // Call the compiler to get the target info JSON.
         let compilerOutput: String
         do {
@@ -106,7 +115,7 @@ extension Triple {
         // Get the triple string from the parsed JSON.
         let tripleString: String
         do {
-            tripleString = try parsedTargetInfo.get("target").get("triple")
+            tripleString = try parsedTargetInfo.get("target").get(versioned ? "triple" : "unversionedTriple")
         } catch {
             throw InternalError(
                 "Target info does not contain a triple string (\(error.interpolationDescription)).\nTarget info: \(parsedTargetInfo)"

Sources/Commands/PackageCommands/AuditBinaryArtifact.swift

@@ -37,7 +37,7 @@ struct AuditBinaryArtifact: AsyncSwiftCommand {
         let hostToolchain = try swiftCommandState.getHostToolchain()
         let clang = try hostToolchain.getClangCompiler()
         let objdump = try hostToolchain.getLLVMObjdump()
-        let hostTriple = try Triple.getHostTriple(
+        let hostTriple = try Triple.getVersionedHostTriple(
             usingSwiftCompiler: hostToolchain.swiftCompilerPath)
         let fileSystem = swiftCommandState.fileSystem
 

Sources/PackageModel/UserToolchain.swift

@@ -200,11 +200,11 @@ public final class UserToolchain: Toolchain {
         }
     }
 
-    private static func getHostTriple(targetInfo: JSON) throws -> Basics.Triple {
+    private static func getHostTriple(targetInfo: JSON, versioned: Bool) throws -> Basics.Triple {
         // Get the triple string from the target info.
         let tripleString: String
         do {
-            tripleString = try targetInfo.get("target").get("triple")
+            tripleString = try targetInfo.get("target").get(versioned ? "triple" : "unversionedTriple")
         } catch {
             throw InternalError(
                 "Target info does not contain a triple string (\(error.interpolationDescription)).\nTarget info: \(targetInfo)"
@@ -741,7 +741,7 @@ public final class UserToolchain: Toolchain {
             // targetInfo from the compiler
             let targetInfo = try customTargetInfo ?? Self.getTargetInfo(swiftCompiler: swiftCompilers.compile)
             self._targetInfo = targetInfo
-            triple = try swiftSDK.targetTriple ?? Self.getHostTriple(targetInfo: targetInfo)
+            triple = try swiftSDK.targetTriple ?? Self.getHostTriple(targetInfo: targetInfo, versioned: false)
         }
 
         // Change the triple to the specified arch if there's exactly one of them.

Sources/SPMBuildCore/BuildParameters/BuildParameters.swift

@@ -173,7 +173,8 @@ public struct BuildParameters: Encodable {
         testingParameters: Testing = .init(),
         apiDigesterMode: APIDigesterMode? = nil
     ) throws {
-        let triple = try triple ?? .getHostTriple(usingSwiftCompiler: toolchain.swiftCompilerPath)
+        // Default to the unversioned triple if none is provided so that we defer to the package's requested deployment target.
+        let triple = try triple ?? .getUnversionedHostTriple(usingSwiftCompiler: toolchain.swiftCompilerPath)
         self.debuggingParameters = debuggingParameters ?? .init(
             triple: triple,
             shouldEnableDebuggingEntitlement: configuration == .debug,

Sources/SwiftSDKCommand/ConfigureSwiftSDK.swift

@@ -117,7 +117,7 @@ struct ConfigureSwiftSDK: AsyncParsableCommand {
         let swiftSDKsDirectory = try self.getOrCreateSwiftSDKsDirectory()
 
         let hostToolchain = try UserToolchain(swiftSDK: SwiftSDK.hostSwiftSDK())
-        let triple = try Triple.getHostTriple(usingSwiftCompiler: hostToolchain.swiftCompilerPath)
+        let triple = try Triple.getVersionedHostTriple(usingSwiftCompiler: hostToolchain.swiftCompilerPath)
 
         var commandError: Error? = nil
         do {

Sources/SwiftSDKCommand/SwiftSDKSubcommand.swift

@@ -68,7 +68,7 @@ extension SwiftSDKSubcommand {
             ),
             environment: environment
         )
-        let triple = try Triple.getHostTriple(usingSwiftCompiler: hostToolchain.swiftCompilerPath)
+        let triple = try Triple.getVersionedHostTriple(usingSwiftCompiler: hostToolchain.swiftCompilerPath)
 
         var commandError: Error? = nil
         do {

Tests/CommandsTests/BuildCommandTests.swift

@@ -1440,6 +1440,63 @@ struct BuildCommandTestCases {
             }
          }
      }
+
+    @Test(.requireHostOS(.macOS), arguments: SupportedBuildSystemOnPlatform)
+    func buildingPackageWhichRequiresOlderDeploymentTarget(buildSystem: BuildSystemProvider.Kind) async throws {
+        // This fixture specifies a deployment target of macOS 12, and uses API obsoleted in macOS 13. The goal
+        // of this test is to ensure that SwiftPM respects the deployment target specified in the package manifest
+        // when passed no triple of an unversioned triple, rather than using the latests deployment target.
+
+        // No triple - build should pass
+        try await fixture(name: "Miscellaneous/RequiresOlderDeploymentTarget") { path in
+                try await executeSwiftBuild(
+                    path,
+                    buildSystem: buildSystem,
+                    throwIfCommandFails: true
+                )
+        }
+
+        let hostArch: String
+        #if arch(arm64)
+        hostArch = "arm64"
+        #else
+        hostArch = "x86_64"
+        #endif
+
+        // Unversioned triple - build should pass
+        try await fixture(name: "Miscellaneous/RequiresOlderDeploymentTarget") { path in
+                try await executeSwiftBuild(
+                    path,
+                    extraArgs: ["--triple", "\(hostArch)-apple-macosx"],
+                    buildSystem: buildSystem,
+                    throwIfCommandFails: true
+                )
+        }
+
+        // Versioned triple with supported deployment target - build should pass
+        try await fixture(name: "Miscellaneous/RequiresOlderDeploymentTarget") { path in
+                try await executeSwiftBuild(
+                    path,
+                    extraArgs: ["--triple", "\(hostArch)-apple-macosx12.0"],
+                    buildSystem: buildSystem,
+                    throwIfCommandFails: true
+                )
+        }
+
+        if buildSystem == .swiftbuild {
+            // Versioned triple with unsupported deployment target - build should fail
+            try await fixture(name: "Miscellaneous/RequiresOlderDeploymentTarget") { path in
+                await #expect(throws: Error.self) {
+                    try await executeSwiftBuild(
+                        path,
+                        extraArgs: ["--triple", "\(hostArch)-apple-macosx14.0"],
+                        buildSystem: buildSystem,
+                        throwIfCommandFails: true
+                    )
+                }
+            }
+        }
+    }
 }
 
 extension Triple {