Fixup several warnings (#9009)

- Remove unnecessary `try` statements for function calls that do not
throw
- Remove unnecessary `#expect` checks for values that cannot be `nil`

Author: plemarquand

Sources/Commands/Utilities/PluginDelegate.swift

@@ -423,8 +423,8 @@ final class PluginDelegate: PluginInvocationDelegate {
             func lookupDescription(
                 for moduleName: String,
                 destination: BuildParameters.Destination
-            ) throws -> ModuleBuildDescription? {
-                try buildPlan.buildModules.first {
+            ) -> ModuleBuildDescription? {
+                buildPlan.buildModules.first {
                     $0.module.name == moduleName && $0.buildParameters.destination == destination
                 }
             }
@@ -434,9 +434,9 @@ final class PluginDelegate: PluginInvocationDelegate {
             // historically how this was setup. Ideally we should be building for both "host"
             // and "target" if module is configured for them but that would require changing
             // `PluginInvocationSymbolGraphResult` to carry multiple directories.
-            let description = if let targetDescription = try lookupDescription(for: targetName, destination: .target) {
+            let description = if let targetDescription = lookupDescription(for: targetName, destination: .target) {
                 targetDescription
-            } else if let hostDescription = try lookupDescription(for: targetName, destination: .host) {
+            } else if let hostDescription = lookupDescription(for: targetName, destination: .host) {
                 hostDescription
             } else {
                 throw InternalError("could not find a target named: \(targetName)")

Sources/Workspace/Workspace+Delegation.swift

@@ -216,7 +216,7 @@ extension WorkspaceDelegate {
     }
 }
 
-struct WorkspaceManifestLoaderDelegate: ManifestLoader.Delegate {
+struct WorkspaceManifestLoaderDelegate: ManifestLoader.Delegate, @unchecked Sendable {
     private weak var workspaceDelegate: Workspace.Delegate?
 
     init(workspaceDelegate: Workspace.Delegate) {
@@ -279,7 +279,7 @@ struct WorkspaceManifestLoaderDelegate: ManifestLoader.Delegate {
     }
 }
 
-struct WorkspaceRepositoryManagerDelegate: RepositoryManager.Delegate {
+struct WorkspaceRepositoryManagerDelegate: RepositoryManager.Delegate, @unchecked Sendable {
     private weak var workspaceDelegate: Workspace.Delegate?
 
     init(workspaceDelegate: Workspace.Delegate) {
@@ -335,7 +335,7 @@ struct WorkspaceRepositoryManagerDelegate: RepositoryManager.Delegate {
     }
 }
 
-struct WorkspaceRegistryDownloadsManagerDelegate: RegistryDownloadsManager.Delegate {
+struct WorkspaceRegistryDownloadsManagerDelegate: RegistryDownloadsManager.Delegate, @unchecked Sendable {
     private weak var workspaceDelegate: Workspace.Delegate?
 
     init(workspaceDelegate: Workspace.Delegate) {

Sources/_InternalTestSupport/GitRepositoryExtensions.swift

@@ -13,6 +13,7 @@
 import SourceControl
 
 import class Basics.AsyncProcess
+import class TSCBasic.Process
 
 import enum TSCUtility.Git
 
@@ -21,7 +22,7 @@ import enum TSCUtility.Git
 package extension GitRepository {
     /// Create the repository using git init.
     func create() throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "init"])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "init")
     }
 
     /// Returns current branch name. If HEAD is on a detached state, this returns HEAD.
@@ -38,36 +39,36 @@ package extension GitRepository {
 
     /// Stage a file.
     func stage(file: String) throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "add", file])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "add", file)
     }
 
     /// Stage multiple files.
     func stage(files: String...) throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "add"] + files)
+        try Process.checkNonZeroExit(arguments: [Git.tool, "-C", self.path.pathString, "add"] + files)
     }
 
     /// Stage entire unstaged changes.
     func stageEverything() throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "add", "."])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "add", ".")
     }
 
     /// Commit the staged changes. If the message is not provided a dummy message will be used for the commit.
     func commit(message: String? = nil) throws {
         // FIXME: We don't need to set these every time but we usually only commit once or twice for a test repo.
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "config", "user.email", "[email protected]"])
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "config", "user.name", "Example Example"])
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "config", "commit.gpgsign", "false"])
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "config", "tag.gpgsign", "false"])
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "commit", "-m", message ?? "Add some files."])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "config", "user.email", "[email protected]")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "config", "user.name", "Example Example")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "config", "commit.gpgsign", "false")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "config", "tag.gpgsign", "false")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "commit", "-m", message ?? "Add some files.")
     }
 
     /// Tag the git repo.
     func tag(name: String) throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "tag", name])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "tag", name)
     }
 
     /// Push the changes to specified remote and branch.
     func push(remote: String, branch: String) throws {
-        try systemQuietly([Git.tool, "-C", self.path.pathString, "push", remote, branch])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", self.path.pathString, "push", remote, branch)
     }
 }

Sources/_InternalTestSupport/InMemoryGitRepository.swift

@@ -396,7 +396,7 @@ extension InMemoryGitRepository: WorkingCheckout {
 extension InMemoryGitRepository: @unchecked Sendable {}
 
 /// This class implement provider for in memory git repository.
-public final class InMemoryGitRepositoryProvider: RepositoryProvider {
+public final class InMemoryGitRepositoryProvider: RepositoryProvider, @unchecked Sendable {
     /// Contains the repository added to this provider.
     public var specifierMap = ThreadSafeKeyValueStore<RepositorySpecifier, InMemoryGitRepository>()
 

Sources/_InternalTestSupport/misc.swift

@@ -32,12 +32,12 @@ import Testing
 import func XCTest.XCTFail
 import struct XCTest.XCTSkip
 
+import class TSCBasic.Process
 import struct TSCBasic.ByteString
 import struct Basics.AsyncProcessResult
 
 import enum TSCUtility.Git
 
-@_exported import func TSCTestSupport.systemQuietly
 @_exported import enum TSCTestSupport.StringPattern
 
 @available(*, deprecated, message: "Use CiEnvironment.runningInSmokeTestPipeline")
@@ -305,7 +305,7 @@ fileprivate func setup(
         #if os(Windows)
         try localFileSystem.copy(from: srcDir, to: dstDir)
         #else
-        try systemQuietly("cp", "-R", "-H", srcDir.pathString, dstDir.pathString)
+        try Process.checkNonZeroExit(args: "cp", "-R", "-H", srcDir.pathString, dstDir.pathString)
         #endif
 
         // Ensure we get a clean test fixture.
@@ -361,17 +361,17 @@ public func initGitRepo(
             try localFileSystem.writeFileContents(file, bytes: "")
         }
 
-        try systemQuietly([Git.tool, "-C", dir.pathString, "init"])
-        try systemQuietly([Git.tool, "-C", dir.pathString, "config", "user.email", "[email protected]"])
-        try systemQuietly([Git.tool, "-C", dir.pathString, "config", "user.name", "Example Example"])
-        try systemQuietly([Git.tool, "-C", dir.pathString, "config", "commit.gpgsign", "false"])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", dir.pathString, "init")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", dir.pathString, "config", "user.email", "[email protected]")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", dir.pathString, "config", "user.name", "Example Example")
+        try Process.checkNonZeroExit(args: Git.tool, "-C", dir.pathString, "config", "commit.gpgsign", "false")
         let repo = GitRepository(path: dir)
         try repo.stageEverything()
         try repo.commit(message: "msg")
         for tag in tags {
             try repo.tag(name: tag)
         }
-        try systemQuietly([Git.tool, "-C", dir.pathString, "branch", "-m", "main"])
+        try Process.checkNonZeroExit(args: Git.tool, "-C", dir.pathString, "branch", "-m", "main")
     } catch {
         XCTFail("\(error.interpolationDescription)", file: file, line: line)
     }

Tests/FunctionalTests/MiscellaneousTests.swift

@@ -277,8 +277,8 @@ final class MiscellaneousTestCase: XCTestCase {
             // Create a shared library.
             let input = systemModule.appending(components: "Sources", "SystemModule.c")
             let triple = try UserToolchain.default.targetTriple
-            let output =  systemModule.appending("libSystemModule\(triple.dynamicLibraryExtension)")
-            try systemQuietly([executableName("clang"), "-shared", input.pathString, "-o", output.pathString])
+            let output = systemModule.appending("libSystemModule\(triple.dynamicLibraryExtension)")
+            try await AsyncProcess.checkNonZeroExit(args: executableName("clang"), "-shared", input.pathString, "-o", output.pathString)
 
             let pcFile = fixturePath.appending("libSystemModule.pc")
 

Tests/FunctionalTests/ModuleMapTests.swift

@@ -30,7 +30,7 @@ final class ModuleMapsTestCase: XCTestCase {
             let outdir = fixturePath.appending(components: rootpkg, ".build", triple.platformBuildPathComponent, "debug")
             try makeDirectories(outdir)
             let output = outdir.appending("libfoo\(triple.dynamicLibraryExtension)")
-            try systemQuietly([executableName("clang"), "-shared", input.pathString, "-o", output.pathString])
+            try await AsyncProcess.checkNonZeroExit(args: executableName("clang"), "-shared", input.pathString, "-o", output.pathString)
 
             var Xld = ["-L", outdir.pathString]
         #if os(Linux) || os(Android)

Tests/FunctionalTests/StaticBinaryLibrary.swift

@@ -24,7 +24,7 @@ struct StaticBinaryLibraryTests {
 
         try await withKnownIssue {
             try await fixture(name: "BinaryLibraries") { fixturePath in
-                let (stdout, stderr) = try await executeSwiftRun(
+                let (stdout, _) = try await executeSwiftRun(
                     fixturePath.appending("Static").appending("Package1"),
                     "Example",
                     extraArgs: ["--experimental-prune-unused-dependencies"],

Tests/IntegrationTests/SwiftPMTests.swift

@@ -20,7 +20,7 @@ import struct SPMBuildCore.BuildSystemProvider
 private struct SwiftPMTests {
     @Test(.requireHostOS(.macOS))
     func binaryTargets() async throws {
-        try await withKnownIssue("error: the path does not point to a valid framework:") {
+        await withKnownIssue("error: the path does not point to a valid framework:") {
             try await binaryTargetsFixture { fixturePath in
                 do {
                     await withKnownIssue("error: local binary target ... does not contain a binary artifact") {

Tests/PackageGraphTests/ModulesGraphTests.swift

@@ -2283,7 +2283,7 @@ struct ModulesGraphTests {
         let observability = try loadUnsafeModulesGraph(toolsVersion: .v6_1)
 
         #expect(observability.diagnostics.count == 3)
-        try testDiagnostics(observability.diagnostics) { result in
+        testDiagnostics(observability.diagnostics) { result in
             var expectedMetadata = ObservabilityMetadata()
             expectedMetadata.moduleName = "Foo2"
             let diagnostic1 = try #require(result.checkUnordered(