PackagingSigning: make some of the private API more public

This extends the visibility of some of the private implementation to the
package level to allow use for testing without `@testable` imports.

Author: compnerd

Sources/PackageSigning/SignatureProvider.swift

@@ -87,7 +87,7 @@ public struct VerifierConfiguration {
     public var certificateRevocation: CertificateRevocation
 
     // for testing
-    init(
+    package init(
         trustedRoots: [[UInt8]],
         includeDefaultTrustStore: Bool,
         certificateExpiration: CertificateExpiration,
@@ -160,7 +160,7 @@ public enum SigningKeyType {
     // RSA support is internal/testing only, thus not included
 }
 
-enum SignatureAlgorithm {
+package enum SignatureAlgorithm {
     case ecdsaP256
     case rsa
 
@@ -198,19 +198,19 @@ protocol SignatureProviderProtocol {
 
 // MARK: - CMS signature provider
 
-struct CMSSignatureProvider: SignatureProviderProtocol {
+package struct CMSSignatureProvider: SignatureProviderProtocol {
     let signatureAlgorithm: SignatureAlgorithm
     let httpClient: HTTPClient
 
-    init(
+    package init(
         signatureAlgorithm: SignatureAlgorithm,
         customHTTPClient: HTTPClient? = .none
     ) {
         self.signatureAlgorithm = signatureAlgorithm
         self.httpClient = customHTTPClient ?? HTTPClient()
     }
 
-    func sign(
+    package func sign(
         content: [UInt8],
         identity: SigningIdentity,
         intermediateCertificates: [[UInt8]],
@@ -264,7 +264,7 @@ struct CMSSignatureProvider: SignatureProviderProtocol {
         }
     }
 
-    func status(
+    package func status(
         signature: [UInt8],
         content: [UInt8],
         verifierConfiguration: VerifierConfiguration,

Sources/PackageSigning/SigningEntity/FilePackageSigningEntityStorage.swift

@@ -20,7 +20,7 @@ import struct TSCUtility.Version
 
 public struct FilePackageSigningEntityStorage: PackageSigningEntityStorage {
     let fileSystem: FileSystem
-    let directoryPath: Basics.AbsolutePath
+    package let directoryPath: Basics.AbsolutePath
 
     private let encoder: JSONEncoder
     private let decoder: JSONDecoder
@@ -231,7 +231,7 @@ private enum StorageModel {
 }
 
 extension PackageIdentity {
-    var signedVersionsFilename: String {
+    package var signedVersionsFilename: String {
         "\(self.description).json"
     }
 }

Sources/PackageSigning/SigningEntity/SigningEntity.swift

@@ -24,7 +24,7 @@ public enum SigningEntity: Hashable, Codable, CustomStringConvertible, Sendable
     case recognized(type: SigningEntityType, name: String, organizationalUnit: String, organization: String)
     case unrecognized(name: String?, organizationalUnit: String?, organization: String?)
 
-    static func from(certificate: Certificate) -> SigningEntity {
+    package static func from(certificate: Certificate) -> SigningEntity {
         let name = certificate.subject.commonName
         let organizationalUnit = certificate.subject.organizationalUnitName
         let organization = certificate.subject.organizationName

Sources/PackageSigning/SigningIdentity.swift

@@ -40,11 +40,11 @@ extension SecIdentity: SigningIdentity {}
 // MARK: - SwiftSigningIdentity is created using raw private key and certificate bytes
 
 public struct SwiftSigningIdentity: SigningIdentity {
-    let certificate: Certificate
+    package let certificate: Certificate
     let privateKey: Certificate.PrivateKey
 
     // for testing
-    init(certificate: Certificate, privateKey: Certificate.PrivateKey) {
+    package init(certificate: Certificate, privateKey: Certificate.PrivateKey) {
         self.certificate = certificate
         self.privateKey = privateKey
     }

Sources/PackageSigning/X509Extensions.swift

@@ -38,7 +38,7 @@ extension Certificate {
         self = try Certificate(Array(data))
     }
 
-    init(secIdentity: SecIdentity) throws {
+    package init(secIdentity: SecIdentity) throws {
         var secCertificate: SecCertificate?
         let status = SecIdentityCopyCertificate(secIdentity, &secCertificate)
         guard status == errSecSuccess, let secCertificate else {
@@ -56,15 +56,15 @@ extension Certificate {
 }
 
 extension DistinguishedName {
-    var commonName: String? {
+    package var commonName: String? {
         self.stringAttribute(oid: ASN1ObjectIdentifier.NameAttributes.commonName)
     }
 
-    var organizationalUnitName: String? {
+    package var organizationalUnitName: String? {
         self.stringAttribute(oid: ASN1ObjectIdentifier.NameAttributes.organizationalUnitName)
     }
 
-    var organizationName: String? {
+    package var organizationName: String? {
         self.stringAttribute(oid: ASN1ObjectIdentifier.NameAttributes.organizationName)
     }
 
@@ -83,7 +83,7 @@ extension DistinguishedName {
 extension Certificate {
     private static let cache = ThreadSafeKeyValueStore<[UInt8], Certificate>()
 
-    init(_ bytes: [UInt8]) throws {
+    package init(_ bytes: [UInt8]) throws {
         if let cached = Self.cache[bytes] {
             self = cached
         } else {