Skip to content

Tests: Migrate MiscellaneousTest to Swift Testing and augment #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Tests: Migrate MiscellaneousTest to Swift Testing and augment #9039

wants to merge 1 commit into from
+821 −473

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Aug 18, 2025 •
edited
Loading

Migrate the MiscellaneousTests suite to Swift Testing and augment the test to run against both the Native and SwiftBuild build system, in addition to the debug and release build configurations.

Depends on: #9013
Depends on: #9115
Depends on: #9224
Relates to: #8997
issue: rdar://157669245

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch 2 times, most recently from 984eb73 to 39ef641 Compare August 18, 2025 20:05
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 18, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from 39ef641 to d08378d Compare August 20, 2025 18:54
@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch 3 times, most recently from d35af32 to f94d37b Compare August 29, 2025 18:07
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 29, 2025

@swift-ci test self hosted

@bkhouri bkhouri mentioned this pull request Aug 29, 2025
Open
1 task
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 2, 2025

@swift-ci test self hosted windows

jakepetroules
jakepetroules reviewed Sep 2, 2025
View reviewed changes
Sources/_InternalTestSupport/BuildSystemProvider+Configuration.swift
) throws -> [String] {
let suffix: String

#if os(Linux)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is based on existing code, but you really want to avoid ifdefs in build system code as much as possible in order to avoid unintentionally breaking cross-compilation scenarios -- this depends on the build target, not the host OS. I'd suggest adding a helper method which deduces this suffix from the triple, then use that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the _InternalTestSupport target, which should only be a test target dependency. As such, we can update this code when we add cross-compilation automated tests.

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from f94d37b to bf196a2 Compare September 3, 2025 18:57
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 9, 2025

@swift-ci test self hosted

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from bf196a2 to 578e6c9 Compare September 9, 2025 14:19
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 9, 2025

@swift-ci test self hosted

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from 578e6c9 to e25b3d2 Compare September 9, 2025 18:43
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 9, 2025

@swift-ci test self hosted

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from e25b3d2 to dfe4db7 Compare September 9, 2025 18:59
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 9, 2025

@swift-ci test self hosted

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 10, 2025

@swift-ci test self hosted windows

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from dfe4db7 to 69e2fce Compare September 12, 2025 19:29
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 12, 2025

@swift-ci test self hosted

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 16, 2025

@swift-ci test windows self hosted

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from 69e2fce to 28ad4c4 Compare October 6, 2025 17:33
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 6, 2025

@swift-ci test self hosted

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from 28ad4c4 to 74edec8 Compare October 6, 2025 19:41
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 6, 2025

@swift-ci test self hosted

@bkhouri
Tests: Migrate MiscellaneousTest to Swift Testing and augment
0d25863 
Migrate the `MiscellaneousTests` suite to Swift Testing and augment
the test to run against both the Native and SwiftBuild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9013
Relates to: swiftlang#8997
issue: rdar://157669245
@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment branch from 74edec8 to 0d25863 Compare October 7, 2025 14:29
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 7, 2025

@swift-ci test self hosted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules left review comments

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 will be requested when the pull request is marked ready for review dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam will be requested when the pull request is marked ready for review shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca will be requested when the pull request is marked ready for review bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand will be requested when the pull request is marked ready for review plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv will be requested when the pull request is marked ready for review owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 will be requested when the pull request is marked ready for review cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 will be requested when the pull request is marked ready for review daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 will be requested when the pull request is marked ready for review rconnell9 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkhouri @jakepetroules