Apply suggestions from code review

MaxDesiatov · web-flow · commit 7164b86ea009 · 2025-03-12T11:05:59.000Z
diff --git a/Tests/SwiftSDKGeneratorTests/EndToEndTests.swift b/Tests/SwiftSDKGeneratorTests/EndToEndTests.swift
@@ -336,8 +336,8 @@ func buildTestcases(config: SDKConfiguration) async throws {
   logger.info("Built Swift SDK")
 
   // Cleanup
-  let cleanupSdk: () async -> Void = {
-    logger.info("Removing Swift SDK to cleanup...")
+  func cleanupSDK() async {
+    logger.info("Removing Swift SDK to clean up...")
     try? await Shell.run("swift experimental-sdk remove \(bundleName)")
   }
 
@@ -349,12 +349,12 @@ func buildTestcases(config: SDKConfiguration) async throws {
         )
       }
     } catch {
-      await cleanupSdk()
+      await cleanupSDK()
       throw error
     }
   }
 
-  await cleanupSdk()
+  await cleanupSDK()
 }
 
 final class Swift59_UbuntuEndToEndTests: XCTestCase {

Original file line number	Diff line number	Diff line change
`@@ -336,8 +336,8 @@ func buildTestcases(config: SDKConfiguration) async throws {`
`336`	`336`	`logger.info("Built Swift SDK")`
`337`	`337`
`338`	`338`	`// Cleanup`
`339`		`- let cleanupSdk: () async -> Void = {`
`340`		`- logger.info("Removing Swift SDK to cleanup...")`
	`339`	`+ func cleanupSDK() async {`
	`340`	`+ logger.info("Removing Swift SDK to clean up...")`
`341`	`341`	`try? await Shell.run("swift experimental-sdk remove \(bundleName)")`
`342`	`342`	`}`
`343`	`343`
`@@ -349,12 +349,12 @@ func buildTestcases(config: SDKConfiguration) async throws {`
`349`	`349`	`)`
`350`	`350`	`}`
`351`	`351`	`} catch {`
`352`		`- await cleanupSdk()`
	`352`	`+ await cleanupSDK()`
`353`	`353`	`throw error`
`354`	`354`	`}`
`355`	`355`	`}`
`356`	`356`
`357`		`- await cleanupSdk()`
	`357`	`+ await cleanupSDK()`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`final class Swift59_UbuntuEndToEndTests: XCTestCase {`