Skip to content

Commit bf28554

Browse files
committed
Split-off versions of SwiftLint that no longer compile on Linux
One of SwiftLint's dependencies is SWXMLHash. In versions of that package prior to its 5.0.0 release, the XMLParser type was imported from Foundation. But, that type has since moved on Linux platforms to the FoundationXML module. This leads to build failures such as: swift-source-compat-suite/project_cache/SwiftLint/.build/ checkouts/SWXMLHash/Source/SWXMLHash.swift:296:38: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it. func parser(_ parser: Foundation.XMLParser, ^~~~~~~~~ SwiftLint updated its dependency on SWXMLHash to be >= 5.0.0 in f5174b316878793e4c24b63741459c1b852f480b, which happened on Oct 8th, 2019, a little after Swift 5.1 compatability was implemented. Thus, this patch marks all versions of SwiftLint that are tagged for 5.1 compatability as only compatible with Darwin, under the new name "SwiftLint-Legacy", so that we still test those versions of SwiftLint. Next, I have created a new SwiftLint path that includes both Darwin and Linux, and forwarded their compatability tests to test SwiftLint's Swift 5.2 and Swift 5.3 releases. Resolves rdar://83374141
1 parent fe1785b commit bf28554

File tree

1 file changed

+31
-1
lines changed

1 file changed

+31
-1
lines changed

projects.json

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2977,7 +2977,7 @@
29772977
{
29782978
"repository": "Git",
29792979
"url": "https://github.com/realm/SwiftLint.git",
2980-
"path": "SwiftLint",
2980+
"path": "SwiftLint-Legacy",
29812981
"branch": "master",
29822982
"compatibility": [
29832983
{
@@ -2998,6 +2998,36 @@
29982998
}
29992999
],
30003000
"maintainer": "[email protected]",
3001+
"platforms": [
3002+
"Darwin"
3003+
],
3004+
"actions": [
3005+
{
3006+
"action": "BuildSwiftPackage",
3007+
"configuration": "release",
3008+
"tags": "sourcekit-disabled swiftpm"
3009+
},
3010+
{
3011+
"action": "TestSwiftPackage"
3012+
}
3013+
]
3014+
},
3015+
{
3016+
"repository": "Git",
3017+
"url": "https://github.com/realm/SwiftLint.git",
3018+
"path": "SwiftLint",
3019+
"branch": "master",
3020+
"compatibility": [
3021+
{
3022+
"version": "5.2",
3023+
"commit": "180d94132758dd183124ab1e63d6aa8e10023ec2"
3024+
},
3025+
{
3026+
"version": "5.3",
3027+
"commit": "e820e750b08bd67bc9d98f4817868e9bc3d5d865"
3028+
}
3029+
],
3030+
"maintainer": "[email protected]",
30013031
"platforms": [
30023032
"Darwin",
30033033
"Linux"

0 commit comments

Comments
 (0)