Disable testWriteToClosedPipe() and testReadFromClosedPipe() because we can't safely write to / read from a closed fd

Author: iCharlesHu

Sources/Subprocess/Platforms/Subprocess+Linux.swift

@@ -225,9 +225,9 @@ private func monitorThreadFunc(context: MonitorThreadContext) {
         repeating: epoll_event(events: 0, data: epoll_data(fd: 0)),
         count: 256
     )
-    var waitMask = sigset_t();
-    sigemptyset(&waitMask);
-    sigaddset(&waitMask, SIGCHLD);
+    var waitMask = sigset_t()
+    sigemptyset(&waitMask)
+    sigaddset(&waitMask, SIGCHLD)
     // Enter the monitor loop
     monitorLoop: while true {
         let eventCount = epoll_pwait(

Sources/Subprocess/Thread.swift

@@ -106,7 +106,7 @@ private final class WorkQueue: Sendable {
         #if canImport(WinSDK)
         EnterCriticalSection(self.mutex)
         defer {
-            LeaveCriticalSection(self.mutex);
+            LeaveCriticalSection(self.mutex)
         }
         #else
         pthread_mutex_lock(self.mutex)
@@ -140,7 +140,7 @@ private final class WorkQueue: Sendable {
         self.withLock { queue in
             queue.append(workItem)
             #if canImport(WinSDK)
-            WakeConditionVariable(self.waitCondition);
+            WakeConditionVariable(self.waitCondition)
             #else
             pthread_cond_signal(self.waitCondition)
             #endif
@@ -151,7 +151,7 @@ private final class WorkQueue: Sendable {
         self.withLock { queue in
             queue.removeAll()
             #if canImport(WinSDK)
-            WakeConditionVariable(self.waitCondition);
+            WakeConditionVariable(self.waitCondition)
             #else
             pthread_cond_signal(self.waitCondition)
             #endif
@@ -209,8 +209,8 @@ private func _shutdownWorkerThread() {
     }
     _workQueue.shutdown()
     #if canImport(WinSDK)
-    WaitForSingleObject(thread, INFINITE);
-    CloseHandle(thread);
+    WaitForSingleObject(thread, INFINITE)
+    CloseHandle(thread)
     DeleteCriticalSection(_workQueue.mutex)
     // We do not need to destroy CONDITION_VARIABLE
     #else
@@ -225,7 +225,7 @@ private func _shutdownWorkerThread() {
 // MARK: - AtomicCounter
 
 #if canImport(Darwin)
-// Unfortunately on Darwin we can unconditionally use Atomic since it requires macOS 15
+// Unfortunately on Darwin we cannot unconditionally use Atomic since it requires macOS 15
 internal struct AtomicCounter: ~Copyable {
     private let storage: OSAllocatedUnfairLock<UInt8>
 

Tests/SubprocessTests/AsyncIOTests.swift

@@ -135,7 +135,8 @@ extension SubprocessAsyncIOTests {
 
 // MARK: - Error Handling Tests
 extension SubprocessAsyncIOTests {
-    @Test func testWriteToClosedPipe() async throws {
+    @Test(.disabled("Cannot safely write to a closed fd without risking it being reused"))
+    func testWriteToClosedPipe() async throws {
         var pipe = try CreatedPipe(closeWhenDone: true, purpose: .input)
         var writeChannel = try _require(pipe.writeFileDescriptor()).createIOChannel()
         var readChannel = try _require(pipe.readFileDescriptor()).createIOChannel()
@@ -171,7 +172,8 @@ extension SubprocessAsyncIOTests {
 
     }
 
-    @Test func testReadFromClosedPipe() async throws {
+    @Test(.disabled("Cannot safely read from a closed fd without risking it being reused"))
+    func testReadFromClosedPipe() async throws {
         var pipe = try CreatedPipe(closeWhenDone: true, purpose: .input)
         var writeChannel = try _require(pipe.writeFileDescriptor()).createIOChannel()
         var readChannel = try _require(pipe.readFileDescriptor()).createIOChannel()