Skip to content

CMake fixes to allow use in dependent projects #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2025
Merged

CMake fixes to allow use in dependent projects #196

merged 3 commits into from
Oct 5, 2025

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Oct 5, 2025

  1. Define SUBPROCESS_ASYNCIO_DISPATCH on macOS/BSDs to fix a build failure
  2. Create SwiftSubprocessConfig.cmake to allow dependent CMake projects to find exported targets

@owenv owenv requested a review from iCharlesHu as a code owner October 5, 2025 03:04
@owenv owenv force-pushed the owenv/cmake-fixes branch 2 times, most recently from fcf94ed to 21c9559 Compare October 5, 2025 03:09
@owenv owenv force-pushed the owenv/cmake-fixes branch from 21c9559 to 4530131 Compare October 5, 2025 03:10
compnerd
compnerd approved these changes Oct 5, 2025
View reviewed changes
@owenv @compnerd
Apply suggestions from code review
a4589d5 
Co-authored-by: Saleem Abdulrasool <[email protected]>
@owenv owenv merged commit 43158de into swiftlang:main Oct 5, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@iCharlesHu iCharlesHu iCharlesHu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owenv @compnerd @jakepetroules @iCharlesHu