Remove MemberAccessExprSyntax Initializer

Author: kimdv

Sources/SwiftSyntaxBuilder/ConvenienceInitializers.swift

@@ -221,20 +221,6 @@ extension IntegerLiteralExprSyntax: ExpressibleByIntegerLiteral {
   }
 }
 
-// MARK: - MemberAccessExpr
-
-extension MemberAccessExprSyntax {
-  /// Creates a `MemberAccessExpr` using the provided parameters.
-  public init(
-    base: ExprSyntax? = nil,
-    dot: TokenSyntax = .periodToken(),
-    name: String,
-    declNameArguments: DeclNameArgumentsSyntax? = nil
-  ) {
-    self.init(base: base, dot: dot, name: .identifier(name), declNameArguments: declNameArguments)
-  }
-}
-
 // MARK: - StringLiteralExpr
 
 extension String {

Sources/_SwiftSyntaxTestSupport/SyntaxProtocol+Initializer.swift

@@ -74,7 +74,7 @@ private extension TriviaPiece {
       fatalError("Unknown associated value type")
     }
     return ExprSyntax(
-      FunctionCallExprSyntax(callee: MemberAccessExprSyntax(name: label!)) {
+      FunctionCallExprSyntax(callee: ExprSyntax(".\(raw: label!)")) {
         TupleExprElementSyntax(expression: arg)
       }
     )
@@ -137,7 +137,7 @@ extension SyntaxProtocol {
         tokenKindArgument = nil
       } else if case .keyword(let keyword) = tokenKind {
         tokenInitializerName = "keyword"
-        tokenKindArgument = ExprSyntax(MemberAccessExprSyntax(name: String(describing: keyword)))
+        tokenKindArgument = ExprSyntax(".\(raw: keyword)")
       } else if tokenKind.decomposeToRaw().rawKind.defaultText != nil {
         tokenInitializerName = "\(String(describing: tokenKind))Token"
         tokenKindArgument = nil
@@ -147,7 +147,7 @@ extension SyntaxProtocol {
         tokenKindArgument = ExprSyntax(StringLiteralExprSyntax(content: token.text))
       }
       return ExprSyntax(
-        FunctionCallExprSyntax(callee: MemberAccessExprSyntax(name: tokenInitializerName)) {
+        FunctionCallExprSyntax(callee: ExprSyntax(".\(raw: tokenInitializerName)")) {
           if let tokenKindArgument = tokenKindArgument {
             TupleExprElementSyntax(expression: tokenKindArgument)
           }

Tests/SwiftSyntaxBuilderTest/DoStmtTests.swift

@@ -35,11 +35,11 @@ final class DoStmtTests: XCTestCase {
           CatchItemListSyntax {
             CatchItemSyntax(
               pattern: PatternSyntax("Error3"),
-              whereClause: WhereClauseSyntax(guardResult: MemberAccessExprSyntax(base: "error", name: "isError4"))
+              whereClause: WhereClauseSyntax(guardResult: ExprSyntax("error.isError4"))
             )
           }
         ) {
-          ThrowStmtSyntax(expression: MemberAccessExprSyntax(base: "Error4", name: "error3"))
+          ThrowStmtSyntax(expression: ExprSyntax("Error4.error3"))
         },
         CatchClauseSyntax {
           FunctionCallExprSyntax(callee: ExprSyntax("print")) {
@@ -85,11 +85,11 @@ final class DoStmtTests: XCTestCase {
           CatchItemListSyntax {
             CatchItemSyntax(
               pattern: PatternSyntax("Error3"),
-              whereClause: WhereClauseSyntax(guardResult: MemberAccessExprSyntax(base: "error", name: "isError4"))
+              whereClause: WhereClauseSyntax(guardResult: ExprSyntax("error.isError4"))
             )
           }
         ) {
-          ThrowStmtSyntax(expression: MemberAccessExprSyntax(base: "Error4", name: "error3"))
+          ThrowStmtSyntax(expression: ExprSyntax("Error4.error3"))
         },
         CatchClauseSyntax {
           FunctionCallExprSyntax(callee: ExprSyntax("print")) {
@@ -135,11 +135,11 @@ final class DoStmtTests: XCTestCase {
           CatchItemListSyntax {
             CatchItemSyntax(
               pattern: PatternSyntax("Error3"),
-              whereClause: WhereClauseSyntax(guardResult: MemberAccessExprSyntax(base: "error", name: "isError4"))
+              whereClause: WhereClauseSyntax(guardResult: ExprSyntax("error.isError4"))
             )
           }
         ) {
-          ThrowStmtSyntax(expression: MemberAccessExprSyntax(base: "Error4", name: "error3"))
+          ThrowStmtSyntax(expression: ExprSyntax("Error4.error3"))
         },
         CatchClauseSyntax {
           FunctionCallExprSyntax(callee: ExprSyntax("print")) {

Tests/SwiftSyntaxBuilderTest/ExtensionDeclTests.swift

@@ -19,7 +19,7 @@ final class ExtensionDeclTests: XCTestCase {
     let keywords = ["associatedtype", "class"].map { keyword -> VariableDeclSyntax in
       // We need to use `CodeBlock` here to ensure there is braces around.
       let body = CodeBlockSyntax {
-        FunctionCallExprSyntax(callee: MemberAccessExprSyntax(base: "TokenSyntax", name: "\(keyword)Keyword"))
+        FunctionCallExprSyntax(callee: ExprSyntax("TokenSyntax.\(raw: keyword)Keyword"))
       }
 
       return VariableDeclSyntax(