Skip to content

Commit 0737ad9

Browse files
committed
Incorporate feedback
1 parent 0125c44 commit 0737ad9

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

Documentation/ABI/TestContent.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ or returns `false` if it could not generate the relevant content. On successful
9797
return, the caller is responsible for deinitializing the memory at `outValue`
9898
when done with it.
9999

100-
`accessor` is optional. If it is `nil`, the test content record is ignored. The
101-
testing library may, in the future, define record kinds that do not provide an
102-
accessor function (that is, they represent pure compile-time information only.)
100+
If `accessor` is `nil`, the test content record is ignored. The testing library
101+
may, in the future, define record kinds that do not provide an accessor function
102+
(that is, they represent pure compile-time information only.)
103103

104104
The second argument to this function, `hint`, is an optional input that can be
105105
passed to help the accessor function determine if its corresponding test content
@@ -140,15 +140,15 @@ content record that needs to be made available before the accessor is called:
140140
- For test or suite declarations (kind `0x74657374`), this field contains a bit
141141
mask with the following flags currently defined:
142142

143-
| Bit | Description |
144-
|-:|-|
145-
| `1 << 0` | This record contains a suite declaration |
146-
| `1 << 1` | This record contains a parameterized test function declaration |
143+
| Bit | Value | Description |
144+
|-:|-:|-|
145+
| `1 << 0` | `1` | This record contains a suite declaration |
146+
| `1 << 1` | `2` | This record contains a parameterized test function declaration |
147147

148-
Other bits are currently always set to `0`, but may be used in the future.
148+
Other bits are reserved for future use and must be set to `0`.
149149

150-
- For exit test declarations (kind `0x65786974`), this field is not used and
151-
should be set to `0`.
150+
- For exit test declarations (kind `0x65786974`), this field is reserved for
151+
future use and must be set to `0`.
152152

153153
#### The reserved1 and reserved2 fields
154154

Documentation/Porting.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,12 @@ operation.
134134
> future release.
135135
136136
_Most_ platforms in use today use the ELF image format and will be able to reuse
137-
the implementation used by Linux. That implementation calls `dl_iterate_phdr()`
138-
in the GNU C Library to enumerate available metadata.
137+
the implementation used by Linux.
139138

140-
If you are porting Swift Testing to Classic, `dl_iterate_phdr()` won't be
141-
available, so you'll need to write a custom implementation instead. Assuming
142-
that the Swift compiler emits section information into the resource fork on
143-
Classic, you would use the [Resource Manager](https://developer.apple.com/library/archive/documentation/mac/pdf/MoreMacintoshToolbox.pdf)
139+
Classic does not use the ELF image format, so you'll need to write a custom
140+
implementation of `_testContentSectionBounds()` instead. Assuming that the Swift
141+
compiler emits section information into the resource fork on Classic, you would
142+
use the [Resource Manager](https://developer.apple.com/library/archive/documentation/mac/pdf/MoreMacintoshToolbox.pdf)
144143
to load that information:
145144

146145
```diff

0 commit comments

Comments
 (0)