Remove mismatchedExitConditionDescription (obsolete)

Author: grynspan

Sources/Testing/ExitTests/ExitTest.swift

@@ -527,7 +527,6 @@ func callExitTest(
     expectedExitCondition.isApproximatelyEqual(to: result.exitStatus),
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation

Sources/Testing/Expectations/Expectation.swift

@@ -32,13 +32,6 @@ public struct Expectation: Sendable {
     evaluatedExpression.differenceDescription
   }
 
-  /// A description of the exit condition that was expected to be matched.
-  ///
-  /// If this expectation passed, the value of this property is `nil` because no
-  /// exit test failed.
-  @_spi(Experimental) @_spi(ForToolsIntegrationOnly)
-  public var mismatchedExitConditionDescription: String?
-
   /// Whether the expectation passed or failed.
   ///
   /// An expectation is considered to pass when its condition evaluates to
@@ -102,7 +95,7 @@ extension Expectation {
     /// - Parameter expectation: The real expectation.
     public init(snapshotting expectation: borrowing Expectation) {
       self.evaluatedExpression = expectation.evaluatedExpression
-      self.mismatchedErrorDescription = expectation.mismatchedErrorDescription ?? expectation.mismatchedExitConditionDescription
+      self.mismatchedErrorDescription = expectation.mismatchedErrorDescription
       self.differenceDescription = expectation.differenceDescription
       self.isPassing = expectation.isPassing
       self.isRequired = expectation.isRequired

Sources/Testing/Expectations/ExpectationChecking+Macro.swift

@@ -17,8 +17,6 @@
 ///     contains information about `condition` and its subexpressions (if any.)
 ///   - mismatchedErrorDescription: A description of the thrown error that did
 ///     not match the expectation, if applicable.
-///   - mismatchedExitConditionDescription: A description of the exit condition
-///     of the child process that did not match the expectation, if applicable.
 ///   - comments: An array of comments describing the expectation. This array
 ///     may be empty.
 ///   - isRequired: Whether or not the expectation is required. The value of
@@ -58,7 +56,6 @@ func check(
   _ condition: Bool,
   expectationContext: consuming __ExpectationContext,
   mismatchedErrorDescription: @autoclosure () -> String?,
-  mismatchedExitConditionDescription: @autoclosure () -> String?,
   comments: @autoclosure () -> [Comment],
   isRequired: Bool,
   sourceLocation: SourceLocation
@@ -86,7 +83,6 @@ func check(
   // Since this expectation failed, populate its optional fields which are
   // only evaluated and included lazily upon failure.
   expectation.mismatchedErrorDescription = mismatchedErrorDescription()
-  expectation.mismatchedExitConditionDescription = mismatchedExitConditionDescription()
 
   // Ensure the backtrace is captured here so it has fewer extraneous frames
   // from the testing framework which aren't relevant to the user.
@@ -118,7 +114,6 @@ public func __checkCondition(
     condition,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -144,7 +139,6 @@ public func __checkCondition<T>(
     optionalValue != nil,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -180,7 +174,6 @@ public func __checkConditionAsync(
     condition,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -207,7 +200,6 @@ public func __checkConditionAsync<T>(
     optionalValue != nil,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -242,7 +234,6 @@ public func __checkEscapedCondition(
     condition,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -270,7 +261,6 @@ public func __checkEscapedCondition<T>(
     optionalValue != nil,
     expectationContext: expectationContext,
     mismatchedErrorDescription: nil,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -397,7 +387,6 @@ public func __checkClosureCall(
     success,
     expectationContext: expectationContext,
     mismatchedErrorDescription: mismatchExplanationValue,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -436,7 +425,6 @@ public func __checkClosureCall(
     success,
     expectationContext: expectationContext,
     mismatchedErrorDescription: mismatchExplanationValue,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -546,7 +534,6 @@ public func __checkClosureCall<R>(
     errorMatches,
     expectationContext: expectationContext,
     mismatchedErrorDescription: mismatchExplanationValue,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation
@@ -599,7 +586,6 @@ public func __checkClosureCall<R>(
     errorMatches,
     expectationContext: expectationContext,
     mismatchedErrorDescription: mismatchExplanationValue,
-    mismatchedExitConditionDescription: nil,
     comments: comments(),
     isRequired: isRequired,
     sourceLocation: sourceLocation

Sources/Testing/Issues/Issue.swift

@@ -276,8 +276,6 @@ extension Issue.Kind: CustomStringConvertible {
     case let .expectationFailed(expectation):
       return if let mismatchedErrorDescription = expectation.mismatchedErrorDescription {
         "Expectation failed: \(mismatchedErrorDescription)"
-      } else if let mismatchedExitConditionDescription = expectation.mismatchedExitConditionDescription {
-        "Expectation failed: \(mismatchedExitConditionDescription)"
       } else {
         "Expectation failed: \(expectation.evaluatedExpression.expandedDescription())"
       }