Simplify trait emission a bit

Author: grynspan

Sources/TestingMacros/Support/Additions/WithAttributesSyntaxAdditions.swift

@@ -110,7 +110,7 @@ extension WithAttributesSyntax {
   }
 
   /// The first `@_unavailableInEmbedded` attribute on this instance, if any.
-  var noembeddedAttribute: AttributeSyntax? {
+  var unavailableInEmbeddedAttribute: AttributeSyntax? {
     attributes(named: "_unavailableInEmbedded", inModuleNamed: "Swift").first
   }
 

Sources/TestingMacros/Support/AvailabilityGuards.swift

@@ -140,24 +140,6 @@ private func _createAvailabilityTraitExpr(
   }
 }
 
-/// Create an expression that contains a test trait for symbols that are
-/// unavailable in Embedded Swift.
-///
-/// - Parameters:
-///   - attribute: The `@_unavailableInEmbedded` attribute.
-///   - context: The macro context in which the expression is being parsed.
-///
-/// - Returns: An instance of `ExprSyntax` representing an instance of
-///   ``Trait`` that can be used to prevent a test from running in Embedded
-///   Swift.
-private func _createNoEmbeddedAvailabilityTraitExpr(
-  from attribute: AttributeSyntax,
-  in context: some MacroExpansionContext
-) -> ExprSyntax {
-  let sourceLocationExpr = createSourceLocationExpr(of: attribute, context: context)
-  return ".__unavailableInEmbedded(sourceLocation: \(sourceLocationExpr))"
-}
-
 /// Create an expression that contains test traits for availability (i.e.
 /// `.enabled(if: ...)`).
 ///
@@ -187,8 +169,9 @@ func createAvailabilityTraitExprs(
     _createAvailabilityTraitExpr(from: availability, when: .obsoleted, in: context)
   }
 
-  if let noembeddedAttribute = decl.noembeddedAttribute {
-    result += [_createNoEmbeddedAvailabilityTraitExpr(from: noembeddedAttribute, in: context)]
+  if let attribute = decl.unavailableInEmbeddedAttribute {
+    let sourceLocationExpr = createSourceLocationExpr(of: attribute, context: context)
+    result += [".__unavailableInEmbedded(sourceLocation: \(sourceLocationExpr))"]
   }
 
   return result
@@ -313,7 +296,7 @@ func createSyntaxNode(
   }
 
   // Handle Embedded Swift.
-  if decl.noembeddedAttribute != nil {
+  if decl.unavailableInEmbeddedAttribute != nil {
     result = """
       #if !hasFeature(Embedded)
       \(result)