Skip to content

Commit e5cc7c6

Browse files
committed
Nope, doesn't work, just disable the docs check
1 parent d174b42 commit e5cc7c6

File tree

7 files changed

+10
-25
lines changed

7 files changed

+10
-25
lines changed

.github/workflows/pull_request.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ jobs:
2424
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
2525
with:
2626
license_header_check_project_name: "Swift"
27-
docs_check_container_image: "swift:6.2-noble"
28-
docs_check_additional_arguments: "--emit-digest"
27+
docs_check_enabled: false
2928
format_check_enabled: false
3029
api_breakage_check_enabled: false

Package.swift

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,6 @@ let buildingForEmbedded: Bool = {
3636
return Bool(envvar) ?? ((Int(envvar) ?? 0) != 0)
3737
}()
3838

39-
/// Whether or not we appear to be building the package for the documentation
40-
/// soundness check we run in GitHub Actions.
41-
let buildingForDocumentationSoundnessCheck: Bool = {
42-
Context.environment["ADDITIONAL_DOCC_ARGUMENTS"] != nil
43-
}()
44-
4539
let package = Package(
4640
name: "swift-testing",
4741

@@ -395,12 +389,6 @@ extension Array where Element == PackageDescription.SwiftSetting {
395389
.define("SWT_NO_LIBDISPATCH", .whenEmbedded()),
396390
]
397391

398-
if buildingForDocumentationSoundnessCheck {
399-
result += [
400-
.define("SWT_DOCC", .whenEmbedded()),
401-
]
402-
}
403-
404392
return result
405393
}
406394

Sources/Testing/Attachments/Images/AttachableImageFormat.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
/// @Metadata {
3232
/// @Available(Swift, introduced: 6.3)
3333
/// }
34-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
34+
#if SWT_NO_IMAGE_ATTACHMENTS
3535
@available(*, unavailable, message: "Image attachments are not available on this platform.")
3636
#endif
3737
@available(_uttypesAPI, *)
@@ -80,7 +80,7 @@ public struct AttachableImageFormat: Sendable {
8080

8181
// MARK: -
8282

83-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
83+
#if SWT_NO_IMAGE_ATTACHMENTS
8484
@available(*, unavailable, message: "Image attachments are not available on this platform.")
8585
#endif
8686
@available(_uttypesAPI, *)

Sources/Testing/Attachments/Images/Attachment+_AttachableAsImage.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// See https://swift.org/CONTRIBUTORS.txt for Swift project authors
99
//
1010

11-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
11+
#if SWT_NO_IMAGE_ATTACHMENTS
1212
@available(*, unavailable, message: "Image attachments are not available on this platform.")
1313
#endif
1414
@available(_uttypesAPI, *)
@@ -104,7 +104,7 @@ extension Attachment {
104104
// MARK: -
105105

106106
@_spi(Experimental) // STOP: not part of ST-0014
107-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
107+
#if SWT_NO_IMAGE_ATTACHMENTS
108108
@available(*, unavailable, message: "Image attachments are not available on this platform.")
109109
#endif
110110
@available(_uttypesAPI, *)

Sources/Testing/Attachments/Images/ImageAttachmentError.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
private import _TestingInternals
1212

1313
/// A type representing an error that can occur when attaching an image.
14-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
14+
#if SWT_NO_IMAGE_ATTACHMENTS
1515
@available(*, unavailable, message: "Image attachments are not available on this platform.")
1616
#endif
1717
package enum ImageAttachmentError: Error {
@@ -42,7 +42,7 @@ package enum ImageAttachmentError: Error {
4242
#endif
4343
}
4444

45-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
45+
#if SWT_NO_IMAGE_ATTACHMENTS
4646
@available(*, unavailable, message: "Image attachments are not available on this platform.")
4747
#endif
4848
extension ImageAttachmentError: CustomStringConvertible {

Sources/Testing/Attachments/Images/_AttachableAsImage.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
// Image attachments on Apple platforms conform to AttachableAsCGImage.
1313
#elseif os(Windows)
1414
// Image attachments on Windows platforms conform to AttachableAsIWICBitmapSource.
15-
#elseif SWT_DOCC
16-
// Image attachments aren't supported, but we're just building the docs.
1715
#elseif !SWT_NO_IMAGE_ATTACHMENTS
1816
#error("Platform-specific misconfiguration: support for image attachments requires a platform-specific implementation")
1917
#endif
@@ -28,7 +26,7 @@
2826
/// A future Swift Evolution proposal will promote this protocol to API so
2927
/// that we don't need to underscore its name.
3028
/// }
31-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
29+
#if SWT_NO_IMAGE_ATTACHMENTS
3230
@available(*, unavailable, message: "Image attachments are not available on this platform.")
3331
#endif
3432
@available(_uttypesAPI, *)

Sources/Testing/Attachments/Images/_AttachableImageWrapper.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
/// @Comment {
2121
/// | Windows | [`HBITMAP`](https://learn.microsoft.com/en-us/windows/win32/gdi/bitmaps), [`HICON`](https://learn.microsoft.com/en-us/windows/win32/menurc/icons), [`IWICBitmapSource`](https://learn.microsoft.com/en-us/windows/win32/api/wincodec/nn-wincodec-iwicbitmapsource) (including its subclasses declared by Windows Imaging Component) |
2222
/// }
23-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
23+
#if SWT_NO_IMAGE_ATTACHMENTS
2424
@available(*, unavailable, message: "Image attachments are not available on this platform.")
2525
#endif
2626
@available(_uttypesAPI, *)
@@ -41,7 +41,7 @@ public final class _AttachableImageWrapper<Image>: Sendable where Image: _Attach
4141
}
4242
}
4343

44-
#if SWT_NO_IMAGE_ATTACHMENTS && !SWT_DOCC
44+
#if SWT_NO_IMAGE_ATTACHMENTS
4545
@available(*, unavailable, message: "Image attachments are not available on this platform.")
4646
#endif
4747
@available(_uttypesAPI, *)

0 commit comments

Comments
 (0)