diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index c0049b554..bb435c6b4 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -24,6 +24,5 @@ jobs: with: license_header_check_project_name: "Swift" docs_check_enabled: false - unacceptable_language_check_enabled: false format_check_enabled: false api_breakage_check_enabled: false diff --git a/Dockerfile b/Dockerfile index 1647b0808..5776af6e7 100644 --- a/Dockerfile +++ b/Dockerfile @@ -11,7 +11,7 @@ FROM swiftlang/swift:nightly-main-jammy # Set up the current build user in the same way done in the Swift.org CI system: -# https://github.com/swiftlang/swift-docker/blob/main/swift-ci/master/ubuntu/22.04/Dockerfile +# https://github.com/swiftlang/swift-docker/blob/main/swift-ci/main/ubuntu/22.04/Dockerfile RUN groupadd -g 998 build-user && \ useradd -m -r -u 998 -g build-user build-user diff --git a/Sources/Testing/ExitTests/ExitTest.swift b/Sources/Testing/ExitTests/ExitTest.swift index c1de79091..32e930e0d 100644 --- a/Sources/Testing/ExitTests/ExitTest.swift +++ b/Sources/Testing/ExitTests/ExitTest.swift @@ -263,7 +263,7 @@ extension ExitTest { // code 3 [...]". // // The Wine project's implementation of raise() calls `_exit(3)` by default. - // See https://github.com/wine-mirror/wine/blob/master/dlls/msvcrt/except.c + // See https://github.com/wine-mirror/wine/blob/master/dlls/msvcrt/except.c (ignore-unacceptable-language) // // Finally, an official copy of the UCRT sources (not up to date) is hosted // at https://www.nuget.org/packages/Microsoft.Windows.SDK.CRTSource . That diff --git a/Sources/Testing/ExitTests/SpawnProcess.swift b/Sources/Testing/ExitTests/SpawnProcess.swift index 24303f632..d1f600e2d 100644 --- a/Sources/Testing/ExitTests/SpawnProcess.swift +++ b/Sources/Testing/ExitTests/SpawnProcess.swift @@ -224,7 +224,7 @@ func spawnExecutable( } #if SWT_TARGET_OS_APPLE && DEBUG // Resume the process. - _ = kill(pid, SIGCONT) + _ = kill(pid, SIGCONT) // ignore-unacceptable-language #endif return pid } diff --git a/Sources/Testing/Testing.docc/LimitingExecutionTime.md b/Sources/Testing/Testing.docc/LimitingExecutionTime.md index 9ea346230..f86091fe4 100644 --- a/Sources/Testing/Testing.docc/LimitingExecutionTime.md +++ b/Sources/Testing/Testing.docc/LimitingExecutionTime.md @@ -18,7 +18,7 @@ Some tests may naturally run slowly: they may require significant system resources to complete, may rely on downloaded data from a server, or may otherwise be dependent on external factors. -If a test may hang indefinitely or may consume too many system resources to +If a test might stall indefinitely or might consume too many system resources to complete effectively, consider setting a time limit for it so that it's marked as failing if it runs for an excessive amount of time. Use the ``Trait/timeLimit(_:)-4kzjp`` trait as an upper bound: diff --git a/Tests/TestingTests/IssueTests.swift b/Tests/TestingTests/IssueTests.swift index 6ea1a5827..6abd384fe 100644 --- a/Tests/TestingTests/IssueTests.swift +++ b/Tests/TestingTests/IssueTests.swift @@ -484,7 +484,7 @@ final class IssueTests: XCTestCase { } func testCastAsAnyProtocol() async { - // Sanity check that we parse types cleanly. + // Check that we parse types cleanly. await Test { #expect((1 as Any) is any Numeric) _ = try #require((1 as Any) as? any Numeric) diff --git a/Tests/TestingTests/Support/CartesianProductTests.swift b/Tests/TestingTests/Support/CartesianProductTests.swift index 3cb4f6daf..304fa329e 100644 --- a/Tests/TestingTests/Support/CartesianProductTests.swift +++ b/Tests/TestingTests/Support/CartesianProductTests.swift @@ -37,7 +37,7 @@ struct CartesianProductTests { @Test("First element is correct") func firstElement() throws { - // Sanity-check the first element is correct. (This value is also tested in + // Check that the first element is correct. (This value is also tested in // testCompleteEquality().) let (c1, c2, product) = computeCartesianProduct() let first = try #require(product.first(where: { _ in true }))