Skip to content

Commit 01eb399

Browse files
committed
CMake: Runtime: Enable tracing on Apple platforms
Adding tracing to concurrency, and enable tracing on the standard library on Apple OSs. rdar://164925172
1 parent 5cc8264 commit 01eb399

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

Runtimes/Core/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,11 @@ defaulted_option(SwiftCore_ENABLE_RUNTIME_OS_VERSIONING "Enable runtime OS versi
106106
defaulted_option(SwiftCore_ENABLE_STATIC_PRINT "Disable full print")
107107
defaulted_option(SwiftCore_ENABLE_COMPACT_ABSOLUTE_FUNCTION_POINTERS "Resolve absolute function pointer as identity")
108108
defaulted_option(SwiftCore_ENABLE_BACKDEPLOYMENT_SUPPORT "Add symbols for runtime backdeployment")
109-
defaulted_option(SwiftCore_ENABLE_STDLIB_TRACING "Enable tracing in the runtime. Assumes the presence of os_log(3) and the os_signpost(3) API.")
110109
defaulted_option(SwiftCore_ENABLE_CONCURRENCY "Enable Concurrency runtime support")
111110
defaulted_option(SwiftCore_ENABLE_REMOTE_MIRROR "Enable RemoteMirror runtime support")
112111
defaulted_option(SwiftCore_ENABLE_DIRECT_RETAIN_RELEASE "Use direct retain release in the runtime/stdlib")
113112
defaulted_set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR STRING "Default Concurrency global executor implementation")
113+
option(SwiftCore_ENABLE_STDLIB_TRACING "Enable tracing in the runtime. Assumes the precense of os_log(3) and the os_signpost(3) API." OFF)
114114
option(SwiftCore_ENABLE_COMMANDLINE_SUPPORT "Enable command line argument support" ON)
115115
option(SwiftCore_ENABLE_UNICODE_DATA "Include unicode data in Swift runtimes" ON)
116116
option(SwiftCore_ENABLE_SHORT_MANGLING_LOOKUPS "Build with fast-path context descriptor lookups based on well-known short manglings." ON)

Runtimes/Core/Concurrency/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ add_library(swift_Concurrency
2222
TaskLocal.cpp
2323
TaskStatus.cpp
2424
ThreadingError.cpp
25-
TracingSignpost.cpp
2625
"${PROJECT_SOURCE_DIR}/CompatibilityOverride/CompatibilityOverride.cpp"
2726
"./linker-support/magic-symbols-for-install-name.c"
2827
Actor.swift
@@ -99,6 +98,13 @@ add_library(swift_Concurrency
9998
"${CMAKE_CURRENT_BINARY_DIR}/TaskGroup+addTask.swift"
10099
"${CMAKE_CURRENT_BINARY_DIR}/Task+immediate.swift")
101100

101+
if(SwiftCore_ENABLE_STDLIB_TRACING)
102+
target_compile_definitions(swift_Concurrency
103+
PRIVATE SWIFT_STDLIB_CONCURRENCY_TRACING)
104+
target_sources(swift_Concurrency
105+
PRIVATE TracingSignpost.cpp)
106+
endif()
107+
102108
if(APPLE)
103109
target_sources(swift_Concurrency PRIVATE
104110
CFExecutor.swift

Runtimes/Core/cmake/caches/Vendors/Apple/apple-common.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ set(SwiftCore_ENABLE_RUNTIME_FUNCTION_COUNTERS ON CACHE BOOL "")
1313
set(SwiftCore_ENABLE_BACKDEPLOYMENT_SUPPORT ON CACHE BOOL "")
1414
set(SwiftCore_ENABLE_FILESYSTEM_SUPPORT ON CACHE BOOL "")
1515
set(SwiftCore_ENABLE_STRICT_AVAILABILITY ON CACHE BOOL "")
16+
set(SwiftCore_ENABLE_STDLIB_TRACING ON CACHE BOOL "")
1617

1718
set(SwiftCore_OPTIMIZATION_REMARKS "bitstream" CACHE STRING "")
1819

0 commit comments

Comments
 (0)