[Mangling] NFC: Remove mangling logic and Ha postfix used by @runtimeMetadata records

Author: xedin

docs/ABI/Mangling.rst

@@ -150,7 +150,6 @@ Globals
   #endif
   global ::= protocol-conformance 'Hc'   // protocol conformance runtime record
   global ::= global 'HF'                 // accessible function runtime record
-  global ::= global 'Ha'                 // runtime discoverable attribute record
 
   global ::= nominal-type 'Mo'           // class metadata immediate member base offset
 

include/swift/Demangling/DemangleNodes.def

@@ -365,8 +365,6 @@ NODE(SymbolicExtendedExistentialType)
 // Added in Swift 5.8
 NODE(MetatypeParamsRemoved)
 NODE(HasSymbolQuery)
-NODE(RuntimeDiscoverableAttributeRecord)
-CONTEXT_NODE(RuntimeAttributeGenerator)
 NODE(OpaqueReturnTypeIndex)
 NODE(OpaqueReturnTypeParent)
 

lib/Demangling/Demangler.cpp

@@ -151,7 +151,6 @@ bool swift::Demangle::isFunctionAttr(Node::Kind kind) {
     case Node::Kind::BackDeploymentThunk:
     case Node::Kind::BackDeploymentFallback:
     case Node::Kind::HasSymbolQuery:
-    case Node::Kind::RuntimeDiscoverableAttributeRecord:
       return true;
     default:
       return false;
@@ -947,7 +946,6 @@ NodePointer Demangler::demangleOperator() {
     case 'H':
       switch (char c2 = nextChar()) {
       case 'A': return demangleDependentProtocolConformanceAssociated();
-      case 'a': return createNode(Node::Kind::RuntimeDiscoverableAttributeRecord);
       case 'C': return demangleConcreteProtocolConformance();
       case 'D': return demangleDependentProtocolConformanceRoot();
       case 'I': return demangleDependentProtocolConformanceInherited();
@@ -1948,7 +1946,6 @@ bool Demangle::nodeConsumesGenericArgs(Node *node) {
     case Node::Kind::PropertyWrapperBackingInitializer:
     case Node::Kind::PropertyWrapperInitFromProjectedValue:
     case Node::Kind::Static:
-    case Node::Kind::RuntimeAttributeGenerator:
       return false;
     default:
       return true;
@@ -3765,10 +3762,6 @@ NodePointer Demangler::demangleFunctionEntity() {
     case 'U': Args = TypeAndIndex; Kind = Node::Kind::ExplicitClosure; break;
     case 'u': Args = TypeAndIndex; Kind = Node::Kind::ImplicitClosure; break;
     case 'A': Args = Index; Kind = Node::Kind::DefaultArgumentInitializer; break;
-    case 'a':
-      Args = ContextArg;
-      Kind = Node::Kind::RuntimeAttributeGenerator;
-      break;
     case 'm': return demangleEntity(Node::Kind::Macro);
     case 'M': return demangleMacroExpansion();
     case 'p': return demangleEntity(Node::Kind::GenericTypeParamDecl);

lib/Demangling/NodePrinter.cpp

@@ -625,8 +625,6 @@ class NodePrinter {
     case Node::Kind::NonUniqueExtendedExistentialTypeShapeSymbolicReference:
     case Node::Kind::SymbolicExtendedExistentialType:
     case Node::Kind::HasSymbolQuery:
-    case Node::Kind::RuntimeDiscoverableAttributeRecord:
-    case Node::Kind::RuntimeAttributeGenerator:
       return false;
     }
     printer_unreachable("bad node kind");
@@ -2244,11 +2242,6 @@ NodePointer NodePrinter::print(NodePointer Node, unsigned depth,
       Printer << "accessible function runtime record for ";
     }
     return nullptr;
-  case Node::Kind::RuntimeDiscoverableAttributeRecord:
-    if (!Options.ShortenThunk) {
-      Printer << "runtime discoverable attribute record for ";
-    }
-    return nullptr;
   case Node::Kind::DynamicallyReplaceableFunctionKey:
     if (!Options.ShortenThunk) {
       Printer << "dynamically replaceable key for ";
@@ -3217,16 +3210,6 @@ NodePointer NodePrinter::print(NodePointer Node, unsigned depth,
   case Node::Kind::HasSymbolQuery:
     Printer << "#_hasSymbol query for ";
     return nullptr;
-  case Node::Kind::RuntimeAttributeGenerator:
-    Printer << "runtime attribute generator of ";
-
-    print(Node->getChild(1), depth);
-
-    printEntity(Node, depth, asPrefixContext,
-                TypePrinting::NoType, /*hasName*/ false,
-                " for attribute");
-
-    return nullptr;
   case Node::Kind::OpaqueReturnTypeIndex:
   case Node::Kind::OpaqueReturnTypeParent:
     return nullptr;
@@ -3363,8 +3346,7 @@ NodePointer NodePrinter::printEntity(NodePointer Entity, unsigned depth,
     if (Entity->getKind() == Node::Kind::DefaultArgumentInitializer ||
         Entity->getKind() == Node::Kind::Initializer ||
         Entity->getKind() == Node::Kind::PropertyWrapperBackingInitializer ||
-        Entity->getKind() == Node::Kind::PropertyWrapperInitFromProjectedValue ||
-        Entity->getKind() == Node::Kind::RuntimeAttributeGenerator) {
+        Entity->getKind() == Node::Kind::PropertyWrapperInitFromProjectedValue) {
       Printer << " of ";
     } else {
       Printer << " in ";

lib/Demangling/OldRemangler.cpp

@@ -2972,16 +2972,3 @@ ManglingError Remangler::mangleHasSymbolQuery(Node *node, unsigned depth) {
   Buffer << "TwS";
   return ManglingError::Success;
 }
-
-ManglingError
-Remangler::mangleRuntimeDiscoverableAttributeRecord(Node *node,
-                                                    unsigned depth) {
-  Buffer << "Ha";
-  return ManglingError::Success;
-}
-
-ManglingError Remangler::mangleRuntimeAttributeGenerator(Node *node,
-                                                         EntityContext &ctx,
-                                                         unsigned depth) {
-  return mangleSimpleEntity(node, 'I', "a", ctx, depth + 1);
-}

lib/Demangling/Remangler.cpp

@@ -575,7 +575,6 @@ ManglingError Remangler::mangleGenericArgs(Node *node, char &Separator,
     case Node::Kind::PropertyWrapperBackingInitializer:
     case Node::Kind::PropertyWrapperInitFromProjectedValue:
     case Node::Kind::Static:
-    case Node::Kind::RuntimeAttributeGenerator:
       if (!fullSubstitutionMap)
         break;
 
@@ -1711,7 +1710,6 @@ ManglingError Remangler::mangleGlobal(Node *node, unsigned depth) {
       case Node::Kind::BackDeploymentThunk:
       case Node::Kind::BackDeploymentFallback:
       case Node::Kind::HasSymbolQuery:
-      case Node::Kind::RuntimeDiscoverableAttributeRecord:
         mangleInReverseOrder = true;
         break;
       default:
@@ -3708,22 +3706,6 @@ mangleNonUniqueExtendedExistentialTypeShapeSymbolicReference(Node *node,
   return MANGLING_ERROR(ManglingError::UnsupportedNodeKind, node);
 }
 
-ManglingError
-Remangler::mangleRuntimeDiscoverableAttributeRecord(Node *node,
-                                                    unsigned depth) {
-  Buffer << "Ha";
-  return ManglingError::Success;
-}
-
-ManglingError
-Remangler::mangleRuntimeAttributeGenerator(Node *node,
-                                           unsigned depth) {
-  RETURN_IF_ERROR(mangleChildNode(node, 0, depth + 1));
-  RETURN_IF_ERROR(mangleChildNode(node, 1, depth + 1));
-  Buffer << "fa";
-  return ManglingError::Success;
-}
-
 } // anonymous namespace
 
 /// The top-level interface to the remangler.
@@ -3799,7 +3781,6 @@ bool Demangle::isSpecialized(Node *node) {
     case Node::Kind::PropertyWrapperBackingInitializer:
     case Node::Kind::PropertyWrapperInitFromProjectedValue:
     case Node::Kind::DefaultArgumentInitializer:
-    case Node::Kind::RuntimeAttributeGenerator:
     case Node::Kind::Getter:
     case Node::Kind::Setter:
     case Node::Kind::WillSet:
@@ -3845,7 +3826,6 @@ ManglingErrorOr<NodePointer> Demangle::getUnspecialized(Node *node,
     case Node::Kind::PropertyWrapperBackingInitializer:
     case Node::Kind::PropertyWrapperInitFromProjectedValue:
     case Node::Kind::DefaultArgumentInitializer:
-    case Node::Kind::RuntimeAttributeGenerator:
     case Node::Kind::Static:
       NumToCopy = node->getNumChildren();
       LLVM_FALLTHROUGH;

lib/IDE/ExprContextAnalysis.cpp

@@ -1234,11 +1234,6 @@ class ExprContextAnalyzer {
       recordPossibleType(AFD->mapTypeIntoContext(var->getInterfaceType()));
       break;
     }
-
-    case InitializerKind::RuntimeAttribute: {
-      // This never appears in AST.
-      break;
-    }
     }
   }