Skip to content

Commit 0c53630

Browse files
author
Julian Lettner
committed
Cleanup outdated comment
In the general case, the compiler should add ptrauth instructions even for simple pointer equality checks. We therefore need to manually avoid these checks; making this workaround permanent.
1 parent 1cacc06 commit 0c53630

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

stdlib/public/runtime/HeapObject.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ static inline bool isValidPointerForNativeRetain(const void *p) {
9090
//
9191
// NOTE: the memcpy and asm("") naming shenanigans are to convince the compiler
9292
// not to emit a bunch of ptrauth instructions just to perform the comparison.
93-
// We only want to authenticate the function pointer if we actually call it. We
94-
// can revert to a straight comparison once rdar://problem/55267009 is fixed.
93+
// We only want to authenticate the function pointer if we actually call it.
9594
SWIFT_RETURNS_NONNULL SWIFT_NODISCARD
9695
static HeapObject *_swift_allocObject_(HeapMetadata const *metadata,
9796
size_t requiredSize,

0 commit comments

Comments
 (0)