[stdlib] replace uses of String(validatingUTF8:)

- use the new name `String(validatingCString:)`

Author: glessard

stdlib/private/StdlibUnittest/InspectValue.swift

@@ -16,7 +16,7 @@ public enum SwiftRuntime {
   private static func _metadataKind<T>(of value: T) -> UnsafePointer<CChar>
 
   public static func metadataKind<T>(of value: T) -> String {
-    return String(validatingUTF8: _metadataKind(of: value))!
+    return String(validatingCString: _metadataKind(of: value))!
   }
 }
 

stdlib/private/StdlibUnittest/StdlibUnittest.swift

@@ -850,7 +850,7 @@ func _printDebuggingAdvice(_ fullTestName: String) {
 #else
   let interpreter = getenv("SWIFT_INTERPRETER")
   if interpreter != nil {
-    if let interpreterCmd = String(validatingUTF8: interpreter!) {
+    if let interpreterCmd = String(validatingCString: interpreter!) {
         invocation.insert(interpreterCmd, at: 0)
     }
   }

stdlib/private/SwiftPrivateLibcExtras/Subprocess.swift

@@ -405,7 +405,7 @@ public func spawnChild(_ args: [String])
   childArgs.insert(CommandLine.arguments[0], at: 0)
   let interpreter = getenv("SWIFT_INTERPRETER")
   if interpreter != nil {
-    if let invocation = String(validatingUTF8: interpreter!) {
+    if let invocation = String(validatingCString: interpreter!) {
       childArgs.insert(invocation, at: 0)
     }
   }

stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift

@@ -64,7 +64,7 @@ internal func getAddressInfoForImage(atIndex i: UInt32) ->
   debugLog("BEGIN \(#function)"); defer { debugLog("END \(#function)") }
   let header = unsafeBitCast(_dyld_get_image_header(i),
           to: UnsafePointer<MachHeader>.self)
-  let name = String(validatingUTF8: _dyld_get_image_name(i)!)!
+  let name = String(validatingCString: _dyld_get_image_name(i)!)!
   var size: UInt = 0
   let address = getsegmentdata(header, "__TEXT", &size)
   return (name, address, size)
@@ -111,7 +111,7 @@ internal func getReflectionInfoForImage(atIndex i: UInt32) -> ReflectionInfo? {
   let capture = getSectionInfo("__swift5_capture", header)
   let typeref = getSectionInfo("__swift5_typeref", header)
   let reflstr = getSectionInfo("__swift5_reflstr", header)
-  return ReflectionInfo(imageName: String(validatingUTF8: imageName)!,
+  return ReflectionInfo(imageName: String(validatingCString: imageName)!,
                         fieldmd: fieldmd,
                         assocty: assocty,
                         builtin: builtin,
@@ -160,7 +160,7 @@ internal func getReflectionInfoForImage(atIndex i: UInt32) -> ReflectionInfo? {
   return _getMetadataSection(UInt(i)).map { rawPointer in
     let name = _getMetadataSectionName(rawPointer)
     let metadataSection = rawPointer.bindMemory(to: MetadataSections.self, capacity: 1).pointee
-    return ReflectionInfo(imageName: String(validatingUTF8: name)!,
+    return ReflectionInfo(imageName: String(validatingCString: name)!,
             fieldmd: Section(range: metadataSection.swift5_fieldmd),
             assocty: Section(range: metadataSection.swift5_assocty),
             builtin: Section(range: metadataSection.swift5_builtin),
@@ -302,7 +302,7 @@ internal func sendReflectionInfos() {
 internal func printErrnoAndExit() {
   debugLog("BEGIN \(#function)"); defer { debugLog("END \(#function)") }
   let errorCString = strerror(errno)!
-  let message = String(validatingUTF8: errorCString)! + "\n"
+  let message = String(validatingCString: errorCString)! + "\n"
   let bytes = Array(message.utf8)
   fwrite(bytes, 1, bytes.count, stderr)
   fflush(stderr)

stdlib/public/Backtracing/Backtrace.swift

@@ -435,7 +435,7 @@ public struct Backtrace: CustomStringConvertible, Sendable {
           _dyld_process_info_for_each_segment(dyldInfo, machHeaderAddress) {
             address, size, name in
 
-            if let name = String(validatingUTF8: name!), name == "__TEXT" {
+            if let name = String(validatingCString: name!), name == "__TEXT" {
               endOfText = address + size
             }
           }

stdlib/public/core/KeyPath.swift

@@ -196,7 +196,7 @@ public class AnyKeyPath: Hashable, _AppendKeyPath {
       }
       guard let ptr = _kvcKeyPathStringPtr else { return nil }
 
-      return String(validatingUTF8: ptr)
+      return String(validatingCString: ptr)
     }
   }
 

stdlib/public/core/OutputStream.swift

@@ -355,7 +355,7 @@ internal func _adHocPrint_unlocked<T, TargetStream: TextOutputStream>(
         target.write(")")
       case .enum:
         if let cString = _getEnumCaseName(value),
-            let caseName = String(validatingUTF8: cString) {
+            let caseName = String(validatingCString: cString) {
           // Write the qualified type name in debugPrint.
           if isDebugPrint {
             printTypeName(mirror.subjectType)
@@ -390,7 +390,7 @@ internal func _adHocPrint_unlocked<T, TargetStream: TextOutputStream>(
   } else {
     // Fall back to the type or an opaque summary of the kind
     if let cString = _opaqueSummary(mirror.subjectType),
-        let opaqueSummary = String(validatingUTF8: cString) {
+        let opaqueSummary = String(validatingCString: cString) {
       target.write(opaqueSummary)
     } else {
       target.write(_typeName(mirror.subjectType, qualified: true))
@@ -532,7 +532,7 @@ internal func _dumpPrint_unlocked<T, TargetStream: TextOutputStream>(
     case .`enum`:
       target.write(_typeName(mirror.subjectType, qualified: true))
       if let cString = _getEnumCaseName(value),
-          let caseName = String(validatingUTF8: cString) {
+          let caseName = String(validatingCString: cString) {
         target.write(".")
         target.write(caseName)
       }

stdlib/public/core/ReflectionMirror.swift

@@ -66,7 +66,7 @@ internal func getChild<T>(of value: T, type: Any.Type, index: Int) -> (label: St
 
   let value = _getChild(of: value, type: type, index: index, outName: &nameC, outFreeFunc: &freeFunc)
 
-  let name = nameC.flatMap({ String(validatingUTF8: $0) })
+  let name = nameC.flatMap({ String(validatingCString: $0) })
   freeFunc?(nameC)
   return (name, value)
 }