[AST] Remove shouldApplyLookDistributedThunk flag from LookupExpr

The underlying mechanism has changed so the flag is no longer required.

Author: xedin

include/swift/AST/Expr.h

@@ -155,11 +155,10 @@ class alignas(8) Expr : public ASTAllocated<Expr> {
 
   SWIFT_INLINE_BITFIELD_EMPTY(LiteralExpr, Expr);
   SWIFT_INLINE_BITFIELD_EMPTY(IdentityExpr, Expr);
-  SWIFT_INLINE_BITFIELD(LookupExpr, Expr, 1+1+1+1,
+  SWIFT_INLINE_BITFIELD(LookupExpr, Expr, 1+1+1,
     IsSuper : 1,
     IsImplicitlyAsync : 1,
-    IsImplicitlyThrows : 1,
-    ShouldApplyDistributedThunk: 1
+    IsImplicitlyThrows : 1
   );
   SWIFT_INLINE_BITFIELD_EMPTY(DynamicLookupExpr, LookupExpr);
 
@@ -1656,18 +1655,6 @@ class LookupExpr : public Expr {
     Bits.LookupExpr.IsImplicitlyThrows = isImplicitlyThrows;
   }
 
-  /// Informs IRGen to that this expression should be applied as its distributed
-  /// thunk, rather than invoking the function directly.
-  ///
-  /// Only intended to be set on distributed get-only computed properties.
-  bool shouldApplyLookupDistributedThunk() const {
-    return Bits.LookupExpr.ShouldApplyDistributedThunk;
-  }
-
-  void setShouldApplyLookupDistributedThunk(bool flag) {
-    Bits.LookupExpr.ShouldApplyDistributedThunk = flag;
-  }
-
   static bool classof(const Expr *E) {
     return E->getKind() >= ExprKind::First_LookupExpr &&
            E->getKind() <= ExprKind::Last_LookupExpr;

lib/AST/ASTDumper.cpp

@@ -2022,9 +2022,6 @@ class PrintExpr : public ExprVisitor<PrintExpr> {
 
   void visitMemberRefExpr(MemberRefExpr *E) {
     printCommon(E, "member_ref_expr");
-    if (E->shouldApplyLookupDistributedThunk()) {
-      OS << " distributed";
-    }
     PrintWithColorRAII(OS, DeclColor) << " decl=";
     printDeclRef(E->getMember());
     if (E->getAccessSemantics() != AccessSemantics::Ordinary)

lib/Sema/TypeCheckConcurrency.cpp

@@ -2319,18 +2319,6 @@ namespace {
           } else {
             return AsyncMarkingResult::NotDistributed;
           }
-
-          // distributed computed property access, mark it throws + async
-          if (auto lookupExpr = dyn_cast_or_null<LookupExpr>(context)) {
-            if (auto memberRef = dyn_cast<MemberRefExpr>(lookupExpr)) {
-              memberRef->setImplicitlyThrows(true);
-              memberRef->setShouldApplyLookupDistributedThunk(true);
-            } else {
-              llvm_unreachable("expected distributed prop to be a MemberRef");
-            }
-          } else {
-            llvm_unreachable("expected distributed prop to have LookupExpr");
-          }
         }
 
         if (auto declRef = dyn_cast_or_null<DeclRefExpr>(context)) {

lib/Sema/TypeCheckDistributed.cpp

@@ -26,7 +26,6 @@
 #include "swift/AST/TypeCheckRequests.h"
 #include "swift/AST/TypeVisitor.h"
 #include "swift/AST/ExistentialLayout.h"
-#include "swift/Basic/Defer.h"
 
 using namespace swift;
 
@@ -577,36 +576,35 @@ bool swift::checkDistributedActorProperty(VarDecl *var, bool diagnose) {
   auto &C = var->getASTContext();
   auto DC = var->getDeclContext();
 
-  DiagnosticTransaction transaction(C.Diags);
-
-  SWIFT_DEFER {
-    if (!diagnose)
-      transaction.abort();
-  };
-
   // without the distributed module, we can't check any of these.
   if (!ensureDistributedModuleLoaded(var))
     return true;
 
   /// === Check if the declaration is a valid combination of attributes
   if (var->isStatic()) {
-    var->diagnose(diag::distributed_property_cannot_be_static,
-                      var->getName());
+    if (diagnose) {
+      var->diagnose(diag::distributed_property_cannot_be_static,
+                    var->getName());
+    }
     // TODO(distributed): fixit, offer removing the static keyword
     return true;
   }
 
   // it is not a computed property
   if (var->isLet() || var->hasStorageOrWrapsStorage()) {
-    var->diagnose(diag::distributed_property_can_only_be_computed,
-                  var->getDescriptiveKind(), var->getName());
+    if (diagnose) {
+      var->diagnose(diag::distributed_property_can_only_be_computed,
+                    var->getDescriptiveKind(), var->getName());
+    }
     return true;
   }
 
   // distributed properties cannot have setters
   if (var->getWriteImpl() != swift::WriteImplKind::Immutable) {
-    var->diagnose(diag::distributed_property_can_only_be_computed_get_only,
-                  var->getName());
+    if (diagnose) {
+      var->diagnose(diag::distributed_property_can_only_be_computed_get_only,
+                    var->getName());
+    }
     return true;
   }