Skip to content

Commit 15c3d96

Browse files
authored
Merge pull request #65628 from tbkka/5.9-tbkka-RemoteMirror-testcleanup
[5.9][RemoteMirror] Test cleanup
2 parents 8bb0ed6 + 9c3044b commit 15c3d96

5 files changed

+10
-12
lines changed

validation-test/Reflection/reflect_Enum_MultiPayload_generic.swift

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ reflect(object: ClassWithEnumDepth0<S>())
4242
// CHECK-NEXT: (bound_generic_class reflect_Enum_MultiPayload_generic.ClassWithEnumDepth0
4343
// CHECK-NEXT: (struct reflect_Enum_MultiPayload_generic.S))
4444

45-
// X64: Type info:
45+
// CHECK: Type info:
46+
4647
// X64-NEXT: (class_instance size=41 alignment=8 stride=48 num_extra_inhabitants=0 bitwise_takable=1
4748
// X64-NEXT: (field name=e offset=16
4849
// X64-NEXT: (single_payload_enum size=25 alignment=8 stride=32 num_extra_inhabitants=253 bitwise_takable=1
@@ -68,7 +69,6 @@ reflect(object: ClassWithEnumDepth0<S>())
6869
// X64-NEXT: (builtin size=8 alignment=8 stride=8 num_extra_inhabitants=0 bitwise_takable=1))))))
6970
// X64-NEXT: (case name=none index=1))))
7071

71-
// X32: Type info:
7272
// X32-NEXT: (class_instance size=21 alignment=4 stride=24 num_extra_inhabitants=0 bitwise_takable=1
7373
// X32-NEXT: (field name=e offset=8
7474
// X32-NEXT: (single_payload_enum size=13 alignment=4 stride=16 num_extra_inhabitants=253 bitwise_takable=1
@@ -110,7 +110,8 @@ reflect(object: ClassWithEnumDepth1<S>())
110110
// CHECK-NEXT: (bound_generic_class reflect_Enum_MultiPayload_generic.ClassWithEnumDepth1
111111
// CHECK-NEXT: (struct reflect_Enum_MultiPayload_generic.S))
112112

113-
// X64: Type info:
113+
// CHECK: Type info:
114+
114115
// X64-NEXT: (class_instance size=41 alignment=8 stride=48 num_extra_inhabitants=0 bitwise_takable=1
115116
// X64-NEXT: (field name=e offset=16
116117
// X64-NEXT: (single_payload_enum size=25 alignment=8 stride=32 num_extra_inhabitants=253 bitwise_takable=1
@@ -136,7 +137,6 @@ reflect(object: ClassWithEnumDepth1<S>())
136137
// X64-NEXT: (builtin size=8 alignment=8 stride=8 num_extra_inhabitants=0 bitwise_takable=1))))))
137138
// X64-NEXT: (case name=none index=1))))
138139

139-
// X32: Type info:
140140
// X32-NEXT: (class_instance size=21 alignment=4 stride=24 num_extra_inhabitants=0 bitwise_takable=1
141141
// X32-NEXT: (field name=e offset=8
142142
// X32-NEXT: (single_payload_enum size=13 alignment=4 stride=16 num_extra_inhabitants=253 bitwise_takable=1
@@ -162,7 +162,6 @@ reflect(object: ClassWithEnumDepth1<S>())
162162
// X32-NEXT: (builtin size=4 alignment=4 stride=4 num_extra_inhabitants=0 bitwise_takable=1))))))
163163
// X32-NEXT: (case name=none index=1))))
164164

165-
166165
doneReflecting()
167166

168167
// CHECK: Done.

validation-test/Reflection/reflect_Enum_MultiPayload_generic2.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ reflect(enum: SimplePayload1<ClassTypeA, Void>.a(ClassTypeA()))
2828
// CHECK-NEXT: (tuple))
2929

3030
// MemoryLayout<SimplePayload1<ClassTypeA, Void>> gives 9,8,16
31-
// SimplePayload1 is a BoundGenericTypeRef
32-
// It's getting laid out as a tagged MPE, not as an SPE
33-
// (an SPE would use the XIs of the ptr) XXXXXX OR WOULD IT??? Hmmmmm....
3431

3532
// CHECK: Type info:
3633
// X64-NEXT: (multi_payload_enum size=9 alignment=8 stride=16 num_extra_inhabitants=254 bitwise_takable=1
@@ -62,8 +59,9 @@ reflect(enum: SimplePayload1<ClassTypeA, Void>.b(()))
6259
// X64-NEXT: (reference kind=strong refcounting=native))
6360
// X64-NEXT: (case name=b index=1 offset=0
6461
// X64-NEXT: (tuple size=0 alignment=1 stride=1 num_extra_inhabitants=0 bitwise_takable=1)))
65-
// X64-NEXT: Mangled name: $s34reflect_Enum_MultiPayload_generic214SimplePayload1OyAA10ClassTypeACytG
66-
// X64-NEXT: Demangled name: reflect_Enum_MultiPayload_generic2.SimplePayload1<reflect_Enum_MultiPayload_generic2.ClassTypeA, ()>
62+
63+
// CHECK: Mangled name: $s34reflect_Enum_MultiPayload_generic214SimplePayload1OyAA10ClassTypeACytG
64+
// CHECK-NEXT: Demangled name: reflect_Enum_MultiPayload_generic2.SimplePayload1<reflect_Enum_MultiPayload_generic2.ClassTypeA, ()>
6765

6866
// CHECK: Enum value:
6967
// CHECK-NEXT: (enum_value name=b index=1

validation-test/Reflection/reflect_Enum_MultiPayload_generic7.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ reflect(enum: B<Int>.c(()))
148148
reflect(enum: B<Void>.a(8))
149149

150150
// CHECK: Reflecting an enum.
151+
151152
// CHECK: Type info:
152153
// X64-NEXT: (multi_payload_enum size=9 alignment=8 stride=16 num_extra_inhabitants=253 bitwise_takable=1
153154
// X64-NEXT: (case name=a index=0 offset=0

validation-test/Reflection/reflect_Enum_MultiPayload_generic8.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ reflect(enum: B<Int>.a(S<Void>(t: ())) as B<Int>?)
9494
// CHECK-NEXT: (bound_generic_enum reflect_Enum_MultiPayload_generic8.B
9595
// CHECK-NEXT: (struct Swift.Int)))
9696

97-
// X64: Type info:
97+
// CHECK: Type info:
9898
// X64-NEXT: (single_payload_enum size=10 alignment=8 stride=16 num_extra_inhabitants=0 bitwise_takable=1
9999
// X64-NEXT: (case name=some index=0 offset=0
100100
// X64-NEXT: (multi_payload_enum size=9 alignment=8 stride=16 num_extra_inhabitants=0 bitwise_takable=1

validation-test/Reflection/reflect_Enum_SinglePayload_generic1.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ reflect(enum: SimplePayload1<ClassTypeA>.b(ClassTypeA()))
3333

3434
// CHECK: Type info:
3535
// X64-NEXT: (single_payload_enum size=8 alignment=8 stride=8 num_extra_inhabitants=2147483645 bitwise_takable=1
36-
// X32-NEXT: FAIL XXX TODO XXX
36+
// X32-NEXT: (single_payload_enum size=4 alignment=4 stride=4 num_extra_inhabitants={{[0-9]+}} bitwise_takable=1
3737
// CHECK-NEXT: (case name=b index=0 offset=0
3838
// CHECK-NEXT: (reference kind=strong refcounting=native))
3939
// CHECK-NEXT: (case name=a index=1)

0 commit comments

Comments
 (0)