Skip to content

Commit 182bfc6

Browse files
committed
[NFC] ClangImporter: Remove some redundant hasParameterList calls
1 parent 3d3b1ca commit 182bfc6

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

lib/ClangImporter/ClangDerivedConformances.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ static FuncDecl *getInsertFunc(NominalTypeDecl *decl,
8181
FuncDecl *insert = nullptr;
8282
for (auto candidate : inserts) {
8383
if (auto candidateMethod = dyn_cast<FuncDecl>(candidate)) {
84-
if (!candidateMethod->hasParameterList())
85-
continue;
8684
auto params = candidateMethod->getParameters();
8785
if (params->size() != 1)
8886
continue;
@@ -158,7 +156,7 @@ static ValueDecl *lookupOperator(NominalTypeDecl *decl, Identifier id,
158156
static ValueDecl *getEqualEqualOperator(NominalTypeDecl *decl) {
159157
auto isValid = [&](ValueDecl *equalEqualOp) -> bool {
160158
auto equalEqual = dyn_cast<FuncDecl>(equalEqualOp);
161-
if (!equalEqual || !equalEqual->hasParameterList())
159+
if (!equalEqual)
162160
return false;
163161
auto params = equalEqual->getParameters();
164162
if (params->size() != 2)
@@ -187,7 +185,7 @@ static FuncDecl *getMinusOperator(NominalTypeDecl *decl) {
187185

188186
auto isValid = [&](ValueDecl *minusOp) -> bool {
189187
auto minus = dyn_cast<FuncDecl>(minusOp);
190-
if (!minus || !minus->hasParameterList())
188+
if (!minus)
191189
return false;
192190
auto params = minus->getParameters();
193191
if (params->size() != 2)
@@ -218,7 +216,7 @@ static FuncDecl *getMinusOperator(NominalTypeDecl *decl) {
218216
static FuncDecl *getPlusEqualOperator(NominalTypeDecl *decl, Type distanceTy) {
219217
auto isValid = [&](ValueDecl *plusEqualOp) -> bool {
220218
auto plusEqual = dyn_cast<FuncDecl>(plusEqualOp);
221-
if (!plusEqual || !plusEqual->hasParameterList())
219+
if (!plusEqual)
222220
return false;
223221
auto params = plusEqual->getParameters();
224222
if (params->size() != 2)

0 commit comments

Comments
 (0)