Sema: Simplify BindingSet::isDirectHole()

slavapestov · slavapestov · commit 19a2eeb32267 · 2025-11-17T11:16:36.000-05:00
diff --git a/lib/Sema/CSBindings.cpp b/lib/Sema/CSBindings.cpp
@@ -103,8 +103,7 @@ bool BindingSet::isDirectHole() const {
   if (!CS.shouldAttemptFixes())
     return false;
 
-  return Bindings.empty() && getNumViableLiteralBindings() == 0 &&
-         Defaults.empty() && TypeVar->getImpl().canBindToHole();
+  return !hasViableBindings() && TypeVar->getImpl().canBindToHole();
 }
 
 static bool isGenericParameter(TypeVariableType *TypeVar) {

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,7 @@ bool BindingSet::isDirectHole() const {`
`103`	`103`	`if (!CS.shouldAttemptFixes())`
`104`	`104`	`return false;`
`105`	`105`
`106`		`- return Bindings.empty() && getNumViableLiteralBindings() == 0 &&`
`107`		`- Defaults.empty() && TypeVar->getImpl().canBindToHole();`
	`106`	`+ return !hasViableBindings() && TypeVar->getImpl().canBindToHole();`
`108`	`107`	`}`
`109`	`108`
`110`	`109`	`static bool isGenericParameter(TypeVariableType *TypeVar) {`