Skip to content

Commit 1a2d8e4

Browse files
committed
Promote feature NonescapableAccessorOnTrivial to be non-experimental
This flag was not experimental for any good reason; it should always be enabled. The flag only exists so we can introduce a new API: UnsafeMutablePointer.mutableSpan. Supported compilers cannot handle the new API. rdar://154247502 (Promote feature NonescapableAccessorOnTrivial to be non-experimental)
1 parent 17ae36e commit 1a2d8e4

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

include/swift/Basic/Features.def

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ LANGUAGE_FEATURE(BuiltinSelect, 0, "Builtin.select")
269269
LANGUAGE_FEATURE(BuiltinInterleave, 0, "Builtin.interleave and Builtin.deinterleave")
270270
LANGUAGE_FEATURE(BuiltinVectorsExternC, 0, "Extern C support for Builtin vector types")
271271
LANGUAGE_FEATURE(AddressOfProperty, 0, "Builtin.unprotectedAddressOf properties")
272+
LANGUAGE_FEATURE(NonescapableAccessorOnTrivial, 0, "Support UnsafeMutablePointer.mutableSpan")
272273

273274
// Swift 6
274275
UPCOMING_FEATURE(ConciseMagicFile, 274, 6)
@@ -531,9 +532,6 @@ EXPERIMENTAL_FEATURE(DefaultIsolationPerFile, false)
531532
/// Enable @_lifetime attribute
532533
SUPPRESSIBLE_EXPERIMENTAL_FEATURE(Lifetimes, true)
533534

534-
/// Enable UnsafeMutablePointer.mutableSpan
535-
EXPERIMENTAL_FEATURE(NonescapableAccessorOnTrivial, true)
536-
537535
#undef EXPERIMENTAL_FEATURE_EXCLUDED_FROM_MODULE_INTERFACE
538536
#undef EXPERIMENTAL_FEATURE
539537
#undef UPCOMING_FEATURE

test/ModuleInterface/lifetime_dependence_test.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ import lifetime_dependence
4848
// CHECK: public var span: Swift.Span<Element> {
4949
// CHECK: @lifetime(borrow self)
5050
// CHECK: @_alwaysEmitIntoClient get {
51-
// CHECK: #if compiler(>=5.3) && $LifetimeDependence && $NonescapableAccessorOnTrivial
51+
// CHECK: #if compiler(>=5.3) && $NonescapableAccessorOnTrivial && $LifetimeDependence
5252
// CHECK: public var mutableSpan: Swift.MutableSpan<Element> {
5353
// CHECK: @lifetime(borrow self)
5454
// CHECK: @_alwaysEmitIntoClient get {

0 commit comments

Comments
 (0)