AST: Fix naming and make a method const, NFC

Author: slavapestov

include/swift/AST/Decl.h

@@ -2415,7 +2415,7 @@ class GenericTypeDecl : public TypeDecl, public DeclContext {
     ValidatingGenericSignature = ivgs;
   }
 
-  bool IsValidatingGenericSignature() {
+  bool isValidatingGenericSignature() const {
     return ValidatingGenericSignature;
   }
 

lib/Sema/TypeCheckDecl.cpp

@@ -6659,7 +6659,7 @@ void TypeChecker::validateDecl(ValueDecl *D, bool resolveTypeParams) {
       // If we're already validating the type declaration's generic signature,
       // avoid a potential infinite loop by not re-validating the generic
       // parameter list.
-      if (!typeAlias->IsValidatingGenericSignature()) {
+      if (!typeAlias->isValidatingGenericSignature()) {
         revertGenericParamList(gp);
 
         auto builder = createArchetypeBuilder(typeAlias->getModuleContext());
@@ -6697,7 +6697,7 @@ void TypeChecker::validateDecl(ValueDecl *D, bool resolveTypeParams) {
       // If we're already validating the type declaration's generic signature,
       // avoid a potential infinite loop by not re-validating the generic
       // parameter list.
-      if (!nominal->IsValidatingGenericSignature()) {
+      if (!nominal->isValidatingGenericSignature()) {
         revertGenericParamList(gp);
 
         ArchetypeBuilder builder =

lib/Sema/TypeCheckGeneric.cpp

@@ -772,7 +772,7 @@ GenericSignature *TypeChecker::validateGenericSignature(
 
 bool TypeChecker::validateGenericTypeSignature(GenericTypeDecl *typeDecl) {
   bool invalid = false;
-  if (!typeDecl->IsValidatingGenericSignature()) {
+  if (!typeDecl->isValidatingGenericSignature()) {
     typeDecl->setIsValidatingGenericSignature();
     auto sig = validateGenericSignature(typeDecl->getGenericParams(),
                                         typeDecl->getDeclContext(),

lib/Sema/TypeCheckType.cpp

@@ -532,7 +532,7 @@ Type TypeChecker::applyUnboundGenericArguments(
 
     // Check the generic arguments against the generic signature.
     auto genericSig = unbound->getDecl()->getGenericSignature();
-    if (unbound->getDecl()->IsValidatingGenericSignature()) {
+    if (unbound->getDecl()->isValidatingGenericSignature()) {
       diagnose(loc, diag::recursive_requirement_reference);
       return nullptr;
     }