Skip to content

Commit 1afaab1

Browse files
committed
This test now passes on Windows
It was fixed by 783d998. C++ doesn't guarantee argument evaluation order apparently, and before that change we were calling visit(), which has side effects, in the argument list of the call to PackExpansionType::get().
1 parent c3a6bfb commit 1afaab1

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

test/SILGen/pack_expansion_type.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
// Experimental features require an asserts compiler
44
// REQUIRES: asserts
55

6-
// XFAIL: OS=windows-msvc
7-
86
// CHECK-LABEL: sil [ossa] @$s19pack_expansion_type16variadicFunction1t1ux_q_txQp_txxQp_q_xQptq_RhzRvzRv_r0_lF : $@convention(thin) <each T, each U where (repeat (each T, each U)) : Any> (@pack_guaranteed Pack{repeat each T}, @pack_guaranteed Pack{repeat each U}) -> @pack_out Pack{repeat (each T, each U)} {
97
// CHECK: bb0(%0 : $*Pack{repeat (each T, each U)}, %1 : $*Pack{repeat each T}, %2 : $*Pack{repeat each U}):
108
public func variadicFunction<each T, each U>(t: repeat each T, u: repeat each U) -> (repeat (each T, each U)) {}

0 commit comments

Comments
 (0)