Fix bit manipulation in ActiveTaskStatus::withEscalatedPriority().

DougGregor · DougGregor · commit 1cac3eee1620 · 2021-07-31T00:24:14.000-07:00
Due to a missing `~` when trying to mask in a new priority + the
`IsEscalated` flag, we were instead getting an incorrect priority as
well as dropping other useful bits. This led to assertions about the
running state of a task not being set.
diff --git a/stdlib/public/Concurrency/TaskPrivate.h b/stdlib/public/Concurrency/TaskPrivate.h
@@ -210,7 +210,7 @@ class alignas(sizeof(void*) * 2) ActiveTaskStatus {
   ActiveTaskStatus withEscalatedPriority(JobPriority priority) const {
     assert(priority > getStoredPriority());
     return ActiveTaskStatus(Record,
-                            (Flags & PriorityMask)
+                            (Flags & ~PriorityMask)
                                | IsEscalated | uintptr_t(priority));
   }
   ActiveTaskStatus withoutStoredPriorityEscalation() const {

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ class alignas(sizeof(void) 2) ActiveTaskStatus {`
`210`	`210`	`ActiveTaskStatus withEscalatedPriority(JobPriority priority) const {`
`211`	`211`	`assert(priority > getStoredPriority());`
`212`	`212`	`return ActiveTaskStatus(Record,`
`213`		`- (Flags & PriorityMask)`
	`213`	`+ (Flags & ~PriorityMask)`
`214`	`214`	`\| IsEscalated \| uintptr_t(priority));`
`215`	`215`	`}`
`216`	`216`	`ActiveTaskStatus withoutStoredPriorityEscalation() const {`