Merge pull request #83096 from hamishknight/ret

[Sema] Set ReturnStmt result even if type-checking fails

Author: hamishknight

lib/Sema/TypeCheckStmt.cpp

@@ -1091,6 +1091,9 @@ class StmtChecker : public StmtVisitor<StmtChecker, Stmt*> {
     if (resultTarget) {
       RS->setResult(resultTarget->getAsExpr());
     } else {
+      // Update the expression even if type-checking failed as e.g pre-checking
+      // may have folded a sequence expr.
+      RS->setResult(target.getAsExpr());
       tryDiagnoseUnnecessaryCastOverOptionSet(getASTContext(), RS->getResult(),
                                               ResultTy);
     }

validation-test/IDE/crashers_fixed/59ed4db5bf91f452.swift

@@ -0,0 +1,6 @@
+// {"kind":"complete","original":"089853e1","signature":"swift::TypeChecker::typeCheckForCodeCompletion(swift::constraints::SyntacticElementTarget&, bool, llvm::function_ref<void (swift::constraints::Solution const&)>)"}
+// RUN: %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
+struct a {
+b:
+func c -> UInt32 {
+0 ^ b#^^#