Skip to content

Commit 247d568

Browse files
committed
build: update update-checkout to ICU 69
Unify the non-Darwin targets to ICU 69. Windows has been using ICU 69 since 5.3, Linux was at 65.
1 parent 4fb2614 commit 247d568

File tree

2 files changed

+4
-20
lines changed

2 files changed

+4
-20
lines changed

utils/build-windows-toolchain.bat

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ if "%TestArg:~-1%"=="," (set TestArg=%TestArg:~0,-1%) else (set TestArg= )
7070
set SkipPackagingArg=-SkipPackaging
7171
if not "%SKIP_PACKAGING%"=="1" set "SkipPackagingArg= "
7272

73-
call :CloneDependencies || (exit /b)
7473
call :CloneRepositories || (exit /b)
7574

7675
:: We only have write access to BuildRoot, so use that as the image root.
@@ -106,7 +105,6 @@ rem git -C "%SourceRoot%\swift" checkout-index --force --all
106105

107106
set "args=%args% --skip-repository swift"
108107
set "args=%args% --skip-repository ninja"
109-
set "args=%args% --skip-repository icu"
110108
set "args=%args% --skip-repository swift-integration-tests"
111109
set "args=%args% --skip-repository swift-stress-tester"
112110
set "args=%args% --skip-repository swift-xcode-playground-support"
@@ -116,17 +114,4 @@ call "%SourceRoot%\swift\utils\update-checkout.cmd" %args% --clone --skip-histor
116114
goto :eof
117115
endlocal
118116

119-
:CloneDependencies
120-
setlocal enableextensions enabledelayedexpansion
121-
122-
:: Always enable symbolic links
123-
git config --global core.symlink true
124-
125-
:: FIXME(compnerd) avoid the fresh clone
126-
rd /s /q icu
127-
git clone --quiet --no-tags --depth 1 --branch maint/maint-69 https://github.com/unicode-org/icu
128-
129-
goto :eof
130-
endlocal
131-
132117
:end

utils/update_checkout/update-checkout-config.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
"remote": { "id": "apple/swift-xcode-playground-support" } },
4747
"ninja": {
4848
"remote": { "id": "ninja-build/ninja" } },
49-
"icu": {
50-
"remote": { "id": "unicode-org/icu" },
51-
"platforms": [ "Linux" ]
52-
},
5349
"yams": {
5450
"remote": { "id": "jpsim/Yams" }
5551
},
@@ -92,6 +88,9 @@
9288
"curl": {
9389
"remote": { "id": "curl/curl" }
9490
},
91+
"icu": {
92+
"remote": { "id": "unicode-org/icu" }
93+
},
9594
"libxml2": {
9695
"remote": { "id": "gnome/libxml2" }
9796
},
@@ -128,7 +127,6 @@
128127
"swift-integration-tests": "main",
129128
"swift-xcode-playground-support": "main",
130129
"ninja": "release",
131-
"icu": "release-65-1",
132130
"yams": "5.0.1",
133131
"cmake": "v3.24.2",
134132
"indexstore-db": "main",
@@ -145,6 +143,7 @@
145143
"swift-experimental-string-processing": "swift/main",
146144
"wasi-libc": "wasi-sdk-20",
147145
"curl": "curl-8_4_0",
146+
"icu": "maint/maint-69",
148147
"libxml2": "v2.11.5",
149148
"zlib": "v1.3"
150149
}

0 commit comments

Comments
 (0)